OCPBUGS-15365: *: use correct clients in the secretannotator #563
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@stevekuznetsov: This pull request references Jira Issue OCPBUGS-15365, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| } | ||
|
|
||
| err = secretutils.WatchCCOConfig(c, types.NamespacedName{ | ||
| err = secretutils.WatchCCOConfig(mgr.GetCache(), c, types.NamespacedName{ |
There was a problem hiding this comment.
This is a bit tricky - we're triggering reconciliation in the controller (based on the root cred manager) by using events for the CCO config that come from the other manager's cache. We did the same in the actuators but in the other direction, one cache with configmap events driving the other reconciler.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #563 +/- ##
=======================================
Coverage 48.00% 48.00%
=======================================
Files 93 93
Lines 11613 11613
=======================================
Hits 5575 5575
Misses 5411 5411
Partials 627 627
|
stevekuznetsov
force-pushed
the
skuznets/more-configmap-pruning
branch
from
0a6f280 to
25bccd3
Compare
We were (again) accidentally watching all ConfigMaps in the cluster. This patch should fix the errant code by using the correct client as well as by removing the RBAC to do so in the first place. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/more-configmap-pruning
branch
from
25bccd3 to
5530e6e
Compare
|
/cc @abutcher |
|
@stevekuznetsov: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abutcher, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@stevekuznetsov: Jira Issue OCPBUGS-15365: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-15365 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…nfigmap-pruning OCPBUGS-15365: *: use correct clients in the secretannotator
5 participants
We were (again) accidentally watching all ConfigMaps in the cluster. This patch should fix the errant code by using the correct client as well as by removing the RBAC to do so in the first place.