Skip to content

OCPBUGS-15365: manifests: fix rbac #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 14, 2023
Merged

OCPBUGS-15365: manifests: fix rbac #567

openshift-merge-robot merged 1 commit into from
Jul 14, 2023

Conversation

@stevekuznetsov
Copy link
Contributor

@stevekuznetsov stevekuznetsov commented Jul 14, 2023

We can't restrict CREATE with resourceNames, since the final name of the object is potentially unknown at admission time.

@stevekuznetsov
manifests: fix rbac
1893819 
We can't restrict CREATE with resourceNames, since the final name of the
object is potentially unknown at admission time.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jul 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 14, 2023

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-15365, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianping-shu

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We can't restrict CREATE with resourceNames, since the final name of the object is potentially unknown at admission time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 14, 2023
@openshift-ci openshift-ci bot requested a review from jianping-shu July 14, 2023 13:25
@abutcher
Copy link
Member

abutcher commented Jul 14, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot requested review from dlom and lleshchi July 14, 2023 13:29
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2023
@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Jul 14, 2023

/test e2e-aws-manual-oidc

@abutcher
Copy link
Member

abutcher commented Jul 14, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2023
@stevekuznetsov
Copy link
Contributor Author

stevekuznetsov commented Jul 14, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2023

@stevekuznetsov: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0c80cc3 into openshift:master Jul 14, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 14, 2023

@stevekuznetsov: Jira Issue OCPBUGS-15365: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15365 has been moved to the MODIFIED state.

Details

In response to this:

We can't restrict CREATE with resourceNames, since the final name of the object is potentially unknown at admission time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025
@openshift-merge-robot
Merge pull request openshift#567 from stevekuznetsov/skuznets/fix-rbac
86fbe95 
OCPBUGS-15365: manifests: fix rbac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jianping-shu jianping-shu Awaiting requested review from jianping-shu

@dlom dlom Awaiting requested review from dlom

@lleshchi lleshchi Awaiting requested review from lleshchi

Assignees

@abutcher abutcher

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stevekuznetsov @openshift-ci-robot @abutcher @openshift-merge-robot