OCPBUGS-15366: [release-4.13] OCPBUGS-15365: operator: use a partial metadata watch for Namespaces #548

openshift-cherrypick-robot · 2023-06-23T13:10:51Z

This is an automated cherry-pick of #546

/assign stevekuznetsov

We only watch namespaces to react to their creation, and the only information we need about a namespace is its' name, so we can use a partial metadata watch to winnow down the size of our cache. Namespaces don't really store much in spec and status, so this effect is likely to not be enormous, but every bit helps. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>

openshift-ci-robot · 2023-06-23T13:10:53Z

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug PORTENABLE-526 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":[],"errors":{"customfield_12318341":"Operation value must be a string"}}

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

This is an automated cherry-pick of #546

/assign stevekuznetsov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stevekuznetsov · 2023-06-23T13:16:34Z

/jira cherrypick PORTENABLE-526

codecov · 2023-06-23T15:36:05Z

Codecov Report

Merging #548 (1d6d6ff) into release-4.13 (0621fca) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.13     #548      +/-   ##
================================================
- Coverage         47.63%   47.60%   -0.03%     
================================================
  Files                94       94              
  Lines             10113    10118       +5     
================================================
  Hits               4817     4817              
- Misses             4721     4726       +5     
  Partials            575      575

Impacted Files	Coverage Δ
...redentialsrequest/credentialsrequest_controller.go	`53.53% <0.00%> (-0.55%)`	⬇️

stevekuznetsov · 2023-06-23T15:58:49Z

/jira cherrypick PORTENABLE-528

stevekuznetsov · 2023-06-23T16:32:29Z

/jira cherrypick PORTENABLE-528

stevekuznetsov · 2023-06-23T16:50:17Z

/retitle [release-4.13] OCPBUGS-15365: operator: use a partial metadata watch for Namespaces

openshift-ci-robot · 2023-06-23T16:50:25Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15365, which is invalid:

expected Jira Issue OCPBUGS-15365 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #546

/assign stevekuznetsov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stevekuznetsov · 2023-06-23T16:52:02Z

/jira cherrypick OCPBUGS-15365

openshift-ci-robot · 2023-06-23T16:52:04Z

@stevekuznetsov: Detected clone of Jira Issue OCPBUGS-15365 with correct target version. Will retitle the PR to link to the clone.
/retitle OCPBUGS-15366: [release-4.13] OCPBUGS-15365: operator: use a partial metadata watch for Namespaces

Details

In response to this:

/jira cherrypick OCPBUGS-15365

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-06-23T16:52:09Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15366, which is invalid:

expected dependent Jira Issue OCPBUGS-15365 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead
expected dependent Jira Issue OCPBUGS-15365 to target a version in 4.14.0, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #546

/assign stevekuznetsov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stevekuznetsov · 2023-06-23T16:53:13Z

/jira refresh

openshift-ci-robot · 2023-06-23T16:53:16Z

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-15366, which is invalid:

expected dependent Jira Issue OCPBUGS-15365 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead
expected dependent Jira Issue OCPBUGS-15365 to target a version in 4.14.0, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abutcher · 2023-06-23T17:53:40Z

/approve
/label backport-risk-assessed

abutcher · 2023-06-23T19:55:00Z

/lgtm

openshift-ci · 2023-06-23T19:57:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [abutcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-07-11T18:36:47Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sjenning · 2023-07-19T13:09:53Z

/jira refresh

openshift-ci-robot · 2023-07-19T13:11:56Z

@sjenning: This pull request references Jira Issue OCPBUGS-15366, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.z) matches configured target version for branch (4.13.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-15365 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-15365 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

Requesting review from QA contact:
/cc @jianping-shu

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jianping-shu · 2023-07-25T03:46:53Z

Had a test with OCP-65165 based on this PR and #551, seems need to port part of codes in #563 too.
After cluster install.

jianpingshu@jshu-mac ~ % kubectl top pods -n openshift-cloud-credential-operator
NAME                                         CPU(cores)   MEMORY(bytes)   
cloud-credential-operator-79fcdb7895-b9zcw   0m           134Mi           
pod-identity-webhook-5f9fb46597-87w89        0m           10Mi            
pod-identity-webhook-5f9fb46597-s67pn        0m           10Mi

Created 100 configmap, ok

jianpingshu@jshu-mac ~ % kubectl top pods -n openshift-cloud-credential-operator
NAME                                         CPU(cores)   MEMORY(bytes)   
cloud-credential-operator-79fcdb7895-b9zcw   1m           132Mi           
pod-identity-webhook-5f9fb46597-87w89        0m           10Mi            
pod-identity-webhook-5f9fb46597-s67pn        0m           10Mi

Created 100 secrets, memory increased obviously

jianpingshu@jshu-mac ~ % kubectl top pods -n openshift-cloud-credential-operator
NAME                                         CPU(cores)   MEMORY(bytes)   
cloud-credential-operator-79fcdb7895-b9zcw   1m           273Mi           
pod-identity-webhook-5f9fb46597-87w89        0m           11Mi            
pod-identity-webhook-5f9fb46597-s67pn        0m           10Mi

stevekuznetsov · 2023-07-25T13:13:44Z

@jianping-shu yes, thank you for the test. I think there's some lack of clarity about whether or not we're going to finish the backport here or not , it depends on some large PRs...

jianping-shu · 2023-07-26T07:37:01Z

@stevekuznetsov Got it! I think we can hold temporarily to wait 4.14 cco is more stable and direction got clearer.

stevekuznetsov · 2023-07-26T12:36:58Z

@jianping-shu makes perfect sense to me

openshift-bot · 2023-10-25T01:01:09Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

stevekuznetsov · 2023-10-25T13:01:27Z

/close

openshift-ci-robot · 2023-10-25T13:04:33Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15366. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #546

/assign stevekuznetsov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-10-25T13:04:36Z

@stevekuznetsov: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Jun 23, 2023

OCPBUGS-15365: operator: use a partial metadata watch for Namespaces #546

Merged

openshift-ci bot assigned stevekuznetsov Jun 23, 2023

openshift-ci bot requested review from dlom and suhanime June 23, 2023 13:13

openshift-ci bot changed the title ~~[release-4.13] PORTENABLE-526: operator: use a partial metadata watch for Namespaces~~ [release-4.13] OCPBUGS-15365: operator: use a partial metadata watch for Namespaces Jun 23, 2023

openshift-ci bot changed the title ~~[release-4.13] OCPBUGS-15365: operator: use a partial metadata watch for Namespaces~~ OCPBUGS-15366: [release-4.13] OCPBUGS-15365: operator: use a partial metadata watch for Namespaces Jun 23, 2023

openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 23, 2023

openshift-ci bot assigned abutcher Jun 23, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 19, 2023

openshift-ci bot requested a review from jianping-shu July 19, 2023 13:12

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2023

openshift-ci bot closed this Oct 25, 2023

OCPBUGS-15366: [release-4.13] OCPBUGS-15365: operator: use a partial metadata watch for Namespaces #548

OCPBUGS-15366: [release-4.13] OCPBUGS-15365: operator: use a partial metadata watch for Namespaces #548

Uh oh!

Conversation

openshift-cherrypick-robot commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 23, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stevekuznetsov commented Jun 23, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

stevekuznetsov commented Jun 23, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stevekuznetsov commented Jun 23, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stevekuznetsov commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 23, 2023

Uh oh!

stevekuznetsov commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 23, 2023

Uh oh!

stevekuznetsov commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 23, 2023

Uh oh!

abutcher commented Jun 23, 2023

Uh oh!

abutcher commented Jun 23, 2023

Uh oh!

openshift-ci bot commented Jun 23, 2023

Uh oh!

openshift-ci bot commented Jul 11, 2023

Uh oh!

sjenning commented Jul 19, 2023

Uh oh!

openshift-ci-robot commented Jul 19, 2023

Uh oh!

jianping-shu commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stevekuznetsov commented Jul 25, 2023

Uh oh!

jianping-shu commented Jul 26, 2023

Uh oh!

stevekuznetsov commented Jul 26, 2023

Uh oh!

openshift-bot commented Oct 25, 2023

Uh oh!

stevekuznetsov commented Oct 25, 2023

Uh oh!

openshift-ci-robot commented Oct 25, 2023

Uh oh!

openshift-ci bot commented Oct 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openshift-ci-robot commented Jun 23, 2023 •

edited by openshift-ci bot

Loading

stevekuznetsov commented Jun 23, 2023 •

edited by openshift-ci bot

Loading

codecov bot commented Jun 23, 2023 •

edited

Loading

stevekuznetsov commented Jun 23, 2023 •

edited by openshift-ci bot

Loading

stevekuznetsov commented Jun 23, 2023 •

edited by openshift-ci bot

Loading

jianping-shu commented Jul 25, 2023 •

edited

Loading