OCPBUGS-15366: [release-4.13] OCPBUGS-15365: manager: filter the cache of configmaps #551

openshift-cherrypick-robot · 2023-06-23T13:11:03Z

This is an automated cherry-pick of #544

/assign stevekuznetsov

This controller LISTs and WATCHes ConfigMaps in order to react to changes to one and only one ConfigMap - the controller's (legacy) configuration. Previously, this controller would hold the entire cluster's ConfigMaps in cache in order to do this; with this change, we will only ever watch one ConfigMap and hold it in memory. This is unfortunately a cross-cutting concern and it blurs the control flow that previously exited, but we need these options to be passed to the cache constructor at the moment we create the manager, so it's not clear that there is a factoring that keeps this from happening until the controller initialization code runs, like where we add filtering today. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>

openshift-ci-robot · 2023-06-23T13:11:06Z

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug PORTENABLE-526 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":[],"errors":{"customfield_12318341":"Operation value must be a string"}}

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

This is an automated cherry-pick of #544

/assign stevekuznetsov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-06-23T15:30:51Z

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0621fca) 47.63% compared to head (ee3981f) 47.59%.
Report is 7 commits behind head on release-4.13.

Additional details and impacted files

@@               Coverage Diff                @@
##           release-4.13     #551      +/-   ##
================================================
- Coverage         47.63%   47.59%   -0.04%     
================================================
  Files                94       94              
  Lines             10113    10121       +8     
================================================
  Hits               4817     4817              
- Misses             4721     4729       +8     
  Partials            575      575

Files	Coverage Δ
pkg/cmd/operator/cmd.go	`0.00% <0.00%> (ø)`

stevekuznetsov · 2023-06-23T16:50:02Z

/retitle [release-4.13] OCPBUGS-15365: manager: filter the cache of configmaps

openshift-ci-robot · 2023-06-23T16:50:09Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15365, which is invalid:

expected Jira Issue OCPBUGS-15365 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #544

/assign stevekuznetsov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stevekuznetsov · 2023-06-23T16:51:01Z

/jira refresh

openshift-ci-robot · 2023-06-23T16:51:03Z

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-15365, which is invalid:

expected Jira Issue OCPBUGS-15365 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stevekuznetsov · 2023-06-23T16:51:56Z

/jira cherrypick OCPBUGS-15365

openshift-ci-robot · 2023-06-23T16:52:01Z

@stevekuznetsov: Jira Issue OCPBUGS-15365 has been cloned as Jira Issue OCPBUGS-15366. Will retitle bug to link to clone.
/retitle OCPBUGS-15366: [release-4.13] OCPBUGS-15365: manager: filter the cache of configmaps

Details

In response to this:

/jira cherrypick OCPBUGS-15365

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-06-23T16:52:06Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15366, which is invalid:

expected dependent Jira Issue OCPBUGS-15365 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead
expected dependent Jira Issue OCPBUGS-15365 to target a version in 4.14.0, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #544

/assign stevekuznetsov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stevekuznetsov · 2023-06-23T16:53:17Z

/jira refresh

openshift-ci-robot · 2023-06-23T16:53:20Z

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-15366, which is invalid:

expected dependent Jira Issue OCPBUGS-15365 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is New instead
expected dependent Jira Issue OCPBUGS-15365 to target a version in 4.14.0, but it targets "4.14" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abutcher · 2023-06-23T17:52:57Z

/approve

abutcher · 2023-06-23T17:53:03Z

/label backport-risk-assessed

abutcher · 2023-06-23T19:55:23Z

/lgtm

openshift-ci · 2023-06-23T19:57:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abutcher, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [abutcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-07-11T18:42:02Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

stevekuznetsov · 2023-07-12T12:39:46Z

/jira refresh

openshift-ci-robot · 2023-07-12T12:39:49Z

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-15366, which is invalid:

expected dependent Jira Issue OCPBUGS-15365 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stevekuznetsov · 2023-07-19T13:22:12Z

/jira refresh

openshift-ci-robot · 2023-07-19T13:22:17Z

@stevekuznetsov: This pull request references Jira Issue OCPBUGS-15366, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.13.z) matches configured target version for branch (4.13.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-15365 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-15365 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
bug has dependents

Requesting review from QA contact:
/cc @jianping-shu

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jstuever · 2023-09-22T18:28:29Z

/uncc

openshift-bot · 2023-12-22T01:00:19Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2024-01-21T08:30:17Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

stevekuznetsov · 2024-01-21T15:35:32Z

/close

openshift-ci · 2024-01-21T15:35:46Z

@stevekuznetsov: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2024-01-21T15:35:51Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15366. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

This is an automated cherry-pick of #544

/assign stevekuznetsov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot mentioned this pull request Jun 23, 2023

OCPBUGS-15365: manager: filter the cache of configmaps #544

Merged

openshift-cherrypick-robot assigned stevekuznetsov Jun 23, 2023

openshift-ci bot requested review from 2uasimojo and jstuever June 23, 2023 13:13

openshift-ci bot changed the title ~~[release-4.13] PORTENABLE-526: manager: filter the cache of configmaps~~ [release-4.13] OCPBUGS-15365: manager: filter the cache of configmaps Jun 23, 2023

openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 23, 2023

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 23, 2023

openshift-ci bot changed the title ~~[release-4.13] OCPBUGS-15365: manager: filter the cache of configmaps~~ OCPBUGS-15366: [release-4.13] OCPBUGS-15365: manager: filter the cache of configmaps Jun 23, 2023

openshift-ci-robot mentioned this pull request Jun 23, 2023

OCPBUGS-15365: operator: use a partial metadata watch for Namespaces #546

Merged

openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 23, 2023

openshift-ci bot assigned abutcher Jun 23, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2023

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 19, 2023

openshift-ci bot requested a review from jianping-shu July 19, 2023 13:22

jianping-shu mentioned this pull request Jul 25, 2023

OCPBUGS-15366: [release-4.13] OCPBUGS-15365: operator: use a partial metadata watch for Namespaces #548

Closed

openshift-ci bot removed the request for review from jstuever September 22, 2023 18:28

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2023

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 21, 2024

openshift-ci bot closed this Jan 21, 2024

OCPBUGS-15366: [release-4.13] OCPBUGS-15365: manager: filter the cache of configmaps #551

OCPBUGS-15366: [release-4.13] OCPBUGS-15365: manager: filter the cache of configmaps #551

Uh oh!

Conversation

openshift-cherrypick-robot commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 23, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

stevekuznetsov commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 23, 2023

Uh oh!

stevekuznetsov commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 23, 2023

Uh oh!

stevekuznetsov commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 23, 2023

Uh oh!

stevekuznetsov commented Jun 23, 2023

Uh oh!

openshift-ci-robot commented Jun 23, 2023

Uh oh!

abutcher commented Jun 23, 2023

Uh oh!

abutcher commented Jun 23, 2023

Uh oh!

abutcher commented Jun 23, 2023

Uh oh!

openshift-ci bot commented Jun 23, 2023

Uh oh!

openshift-ci bot commented Jul 11, 2023

Uh oh!

stevekuznetsov commented Jul 12, 2023

Uh oh!

openshift-ci-robot commented Jul 12, 2023

Uh oh!

stevekuznetsov commented Jul 19, 2023

Uh oh!

openshift-ci-robot commented Jul 19, 2023

Uh oh!

jstuever commented Sep 22, 2023

Uh oh!

openshift-bot commented Dec 22, 2023

Uh oh!

openshift-bot commented Jan 21, 2024

Uh oh!

stevekuznetsov commented Jan 21, 2024

Uh oh!

openshift-ci bot commented Jan 21, 2024

Uh oh!

openshift-ci-robot commented Jan 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci-robot commented Jun 23, 2023 •

edited by openshift-ci bot

Loading

codecov bot commented Jun 23, 2023 •

edited

Loading