Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Apr 17, 2021

Reverts #752

I dunno if this has been causing the "unresolved import actix_service::pipeline_factory" errors or not, but floating a revert and watching it's CI is an easy way to check.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2021
@wking wking added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3b62b30 into master Apr 17, 2021
@wking wking deleted the revert-752-bump-cincy-00395392 branch April 17, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants