Cargo: update dependencies #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
vrutkovs
force-pushed
the
bump-cincy-92863283
branch
from
7832e30 to
21a9911
Compare
* recent Cincinnati commit * tokio 1.5 * lazy_static 1.4.0 * reqwest 0.11 * pin 'actix-http' to 3.0.0-beta.5 as actix-cors is not yet compatible with .6 * pin 'actix-service' to 2.0.0-beta.5 to be compatible with actix-http
vrutkovs
force-pushed
the
bump-cincy-92863283
branch
from
21a9911 to
8fcab34
Compare
Author
Member
|
Do we understand why this isn't hitting the #760 issue? Your new pinning? |
Author
Yup, pins prevent from pulling in unexpected actix-* crates |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned actix-http and actix-service to be compatible with Cincinnati
See #752 for previous attempt