Skip to content

Enable 4.8.0-fc.0 in candidate channel(s) #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 17, 2021
Merged

Enable 4.8.0-fc.0 in candidate channel(s) #759

openshift-merge-robot merged 1 commit into from
Apr 17, 2021

Conversation

@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Apr 16, 2021

This is a release candidate. There is no advisory associated.

Please merge immediately.

@openshift-bot openshift-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Apr 16, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Apr 16, 2021

images:

error[E0432]: unresolved import `actix_service::pipeline_factory`

/retest

@wking wking mentioned this pull request Apr 17, 2021
Merged
@wking
Copy link
Member

wking commented Apr 17, 2021

#760 should have unblocked CI.

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9d99640 into master Apr 17, 2021
@wking wking deleted the pr-candidate-4.8.0-fc.0 branch April 17, 2021 22:41
@wking wking mentioned this pull request Apr 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eparis eparis Awaiting requested review from eparis

@wking wking Awaiting requested review from wking

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-bot @openshift-ci-robot @wking @openshift-merge-robot