-
Notifications
You must be signed in to change notification settings - Fork 65
add 4.3.12 to fast #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 4.3.12 to fast #167
Conversation
|
/hold Blocked on #166 and errata publication. |
|
PR updated. |
| name: fast-4.4 | ||
| versions: [] | ||
| versions: | ||
| - 4.3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any chance this makes us have to block edges later? I can't think of a reason... So I think I like this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we could end up having to block edges later. But edge blocks aren't channel bound so if 4.3.12 to 4.3.13 or 4.3.12 to 4.4.0 were blocked it'd also be blocked here as well.
The primary motivation here is to land releases before console starts letting people choose 4.4 channels so that if someone were to change before we had minor version upgrades we wouldn't orphan them. For instance, I attempted to go from 4.1.0 to 4.2, the biggest upgrades I could take were 4.1.0 to 4.1.14 to 4.1.25 at which point the console let me switch to stable-4.2 and I could no no where.
Maybe I misunderstood the question though.
|
Merge conflicts on our insistence to drop metadata in channel files. I'll rebase. |
|
/assign @jottofar |
|
/unhold |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jottofar, vfreex The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
I've set approved label so this merges, we'd previously agreed that OTA can add items to channels without architect approval but we've not taken action on #173 so that's not possible. |
No description provided.