Skip to content

Conversation

@vfreex
Copy link
Contributor

@vfreex vfreex commented Apr 10, 2020

No description provided.

@wking
Copy link
Member

wking commented Apr 10, 2020

/hold

Blocked on #166 and errata publication.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2020
@vfreex
Copy link
Contributor Author

vfreex commented Apr 10, 2020

PR updated.

name: fast-4.4
versions: []
versions:
- 4.3.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#166 is still open, so this can happen or not without much impact. If it happens, it's along the lines of the abandoned-for-lack-of-interest #116.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance this makes us have to block edges later? I can't think of a reason... So I think I like this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we could end up having to block edges later. But edge blocks aren't channel bound so if 4.3.12 to 4.3.13 or 4.3.12 to 4.4.0 were blocked it'd also be blocked here as well.

The primary motivation here is to land releases before console starts letting people choose 4.4 channels so that if someone were to change before we had minor version upgrades we wouldn't orphan them. For instance, I attempted to go from 4.1.0 to 4.2, the biggest upgrades I could take were 4.1.0 to 4.1.14 to 4.1.25 at which point the console let me switch to stable-4.2 and I could no no where.

Maybe I misunderstood the question though.

@sdodson
Copy link
Member

sdodson commented Apr 14, 2020

Merge conflicts on our insistence to drop metadata in channel files. I'll rebase.

@sdodson
Copy link
Member

sdodson commented Apr 14, 2020

/assign @jottofar
This errata is shipping today.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2020
@jottofar
Copy link
Contributor

/unhold

@jottofar
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@jottofar
Copy link
Contributor

/approve

@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jottofar, vfreex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Apr 15, 2020

I've set approved label so this merges, we'd previously agreed that OTA can add items to channels without architect approval but we've not taken action on #173 so that's not possible.

@openshift-merge-robot openshift-merge-robot merged commit a446bfd into openshift:master Apr 15, 2020
@wking wking mentioned this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants