Skip to content

add 4.3.12 to fast #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Apr 15, 2020
Merged

add 4.3.12 to fast #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions channels/fast-4.3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,4 @@ versions:
- 4.3.9
- 4.3.10
# No 4.3.11 because of build issues: https://bugzilla.redhat.com/show_bug.cgi?id=1823378
- 4.3.12
3 changes: 2 additions & 1 deletion channels/fast-4.4.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
name: fast-4.4
versions: []
versions:
- 4.3.12
Copy link
Member

@wking wking Apr 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#166 is still open, so this can happen or not without much impact. If it happens, it's along the lines of the abandoned-for-lack-of-interest #116.

Copy link
Member

@eparis eparis Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance this makes us have to block edges later? I can't think of a reason... So I think I like this PR.

Copy link
Member

@sdodson sdodson Apr 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we could end up having to block edges later. But edge blocks aren't channel bound so if 4.3.12 to 4.3.13 or 4.3.12 to 4.4.0 were blocked it'd also be blocked here as well.

The primary motivation here is to land releases before console starts letting people choose 4.4 channels so that if someone were to change before we had minor version upgrades we wouldn't orphan them. For instance, I attempted to go from 4.1.0 to 4.2, the biggest upgrades I could take were 4.1.0 to 4.1.14 to 4.1.25 at which point the console let me switch to stable-4.2 and I could no no where.

Maybe I misunderstood the question though.