Drop channels/OWNERS so that it defaults to top level OWNERS #173
Conversation
Net effect being that OTA can add to channels without release-admins Blocks still require release-admins
| # This file just uses aliases defined in OWNERS_ALIASES. | ||
|
|
||
| approvers: | ||
| - release-admins |
There was a problem hiding this comment.
I'd rather have ART own candidate promotions, and cincinnati-graph-data-approvers only own fast/stable promotions. But we can't do that until Cincinnati can load channel YAML recursively from channels/ (which we'd split into channels/candidate and channels/stable or some such).
There was a problem hiding this comment.
Sounds like ART is going to push directly to master, so they don't need to get involved in OWNERS. In that case, I'm fine with this PR as it stands.
There was a problem hiding this comment.
We can come back to it and add ART to the list of approvers when we have ART ready to push to the candidates.
|
/hold for release-admins to approve /lgtm |
openshift-ci-robot
added
the
do-not-merge/hold
Until this merges they have to approve this anyway. I'm going to clear the hold so it pops up on their radar. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, LalatenduMohanty, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
6 participants
Net effect being that OTA can add to channels without release-admins
Blocks still require release-admins