Skip to content

Conversation

@sdodson
Copy link
Member

@sdodson sdodson commented Mar 11, 2020

Splitting #104 which was adding 4.2.21 into stable-4.3 as well because we'd like more telemetry data regarding 4.2.21 to 4.3 edges.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2020
@sdodson
Copy link
Member Author

sdodson commented Mar 11, 2020

Wait on #103

@sdodson
Copy link
Member Author

sdodson commented Mar 11, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2020
@sdodson
Copy link
Member Author

sdodson commented Mar 11, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2020
@jottofar
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020
@eparis
Copy link
Member

eparis commented Mar 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@eparis
Copy link
Member

eparis commented Mar 11, 2020

/approve cancel

@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@eparis
Copy link
Member

eparis commented Mar 11, 2020

why not stable-4.3?

@eparis
Copy link
Member

eparis commented Mar 11, 2020

if I look through git history i'm not going to have any idea why we did this

Do not add 4.2.21 into stable-4.3. We're looking for additional feedback from telemetry still
@sdodson sdodson force-pushed the 4-2-21-stable-4-2 branch from 2714419 to 19a37f6 Compare March 11, 2020 20:28
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020
@eparis
Copy link
Member

eparis commented Mar 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, jottofar, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6f8751a into openshift:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants