Skip to content

Conversation

@joepvd
Copy link
Contributor

@joepvd joepvd commented Mar 10, 2020

Note, there might be legit concerns to add the upgrade path to stable-4.3.

Note, there might be legit concerns to add the upgrade path to
`stable-4.3`.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joepvd
To complete the pull request process, please assign derekwaynecarr
You can assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs
Copy link

/cc @jottofar

@sdodson
Copy link
Member

sdodson commented Mar 10, 2020

Yeah, can you please split the two changes into different PRs?

@sdodson
Copy link
Member

sdodson commented Mar 10, 2020

/hold
Need to split stable-4.3 addition of 4.2 versions for now.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
@LalatenduMohanty
Copy link
Member

Need to split stable-4.3 addition of 4.2 versions for now.

+1

@sdodson
Copy link
Member

sdodson commented Mar 11, 2020

/close
I'll split this

@openshift-ci-robot
Copy link

@sdodson: Closed this PR.

Details

In response to this:

/close
I'll split this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson mentioned this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants