Skip to content

Add 4.2.21 to fast channels #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 11, 2020
Merged

Add 4.2.21 to fast channels #103

openshift-merge-robot merged 1 commit into from
Mar 11, 2020

Conversation

@joepvd
Copy link
Contributor

@joepvd joepvd commented Mar 10, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 10, 2020
@sdodson
Copy link
Member

sdodson commented Mar 11, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2020
@eparis
Copy link
Member

eparis commented Mar 11, 2020

/approve

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Mar 11, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 11, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, joepvd, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2020
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Mar 11, 2020 •
edited
Loading

We had found two issues while adding it to candidate channel


    https://bugzilla.redhat.com/show_bug.cgi?id=1734524 marked UpgradeBlocker
    https://bugzilla.redhat.com/show_bug.cgi?id=1809259

PR for candidate channel #81

@sdodson
Copy link
Member

sdodson commented Mar 11, 2020

My opinion is that we shouldn't block on either of those.

@sdodson sdodson mentioned this pull request Mar 11, 2020
Merged
@sdodson
Copy link
Member

sdodson commented Mar 11, 2020

/hold cancel
:shipit:

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2020
@openshift-merge-robot openshift-merge-robot merged commit a39947d into openshift:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@lucab lucab Awaiting requested review from lucab

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joepvd @sdodson @eparis @LalatenduMohanty @openshift-ci-robot @openshift-merge-robot