add deploy mode for klusterlet#114
add deploy mode for klusterlet#114openshift-merge-robot merged 1 commit intoopen-cluster-management-io:mainfrom
Conversation
zhujian7
force-pushed
the
klusterlet-deploy-mode
branch
from
1b5258a to
0ed3309
Compare
|
/retest |
zhujian7
force-pushed
the
klusterlet-deploy-mode
branch
2 times, most recently
from
222876f to
0ed3309
Compare
|
Because of openshift/build-machinery-go#56, the verity failed. |
zhujian7
changed the title
qiujian16
left a comment
qiujian16
left a comment
There was a problem hiding this comment.
/approve
/assign @zhiweiyin318 @xuezhaojun
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @ianzhang366 |
zhujian7
force-pushed
the
klusterlet-deploy-mode
branch
from
0ed3309 to
931fac6
Compare
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
klusterlet-deploy-mode
branch
from
931fac6 to
a6878c0
Compare
| // - In Detached mode, only crd and configurations are installed on one cluster(defined as hub-cluster). Controllers run in another cluster (defined as management-cluster) and connect to the hub with the kubeconfig in secret of "external-hub-kubeconfig"(a kubeconfig of hub-cluster with cluster-admin permission). | ||
| // For klusterlet: | ||
| // - In Default mode, all klusterlet related resources are deployed on the managed cluster. | ||
| // - In Detached mode, only crd and configurations are installed on the spoke/managed cluster. Controllers run in another cluster (defined as management-cluster) and connect to the mangaged cluster with the kubeconfig in secret of "external-managed-kubeconfig"(a kubeconfig of managed-cluster with cluster-admin permission). |
There was a problem hiding this comment.
@zhujian7 how do we specify the configuration of management-cluster to controllers?
There was a problem hiding this comment.
In fact for registration-agent and work-agent, the configuration here specifically refers to the RBAC configuration(in the managed cluster). Currently, we don't need a configuration resource(cm, in the management cluster) for the controllers(registration-agent and work-agent), all configs are reflected by the flags.
|
/lgtm |
6 participants
Signed-off-by: zhujian jiazhu@redhat.com