Skip to content

[release-4.3] Bug 1802675: Consider mdns hostname file existence in utils.ShortHostname #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 4, 2020
Merged

[release-4.3] Bug 1802675: Consider mdns hostname file existence in utils.ShortHostname #45

openshift-merge-robot merged 1 commit into from
Mar 4, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Feb 13, 2020

This is an automated cherry-pick of #44

/assign celebdor

@yboaronn
Consider mdns hostname file existence in utils.ShortHostname
13b96d7 
The utils.ShortHostname function should read hostname from mdns
hostname (/etc/mdns/hostname), if mdns hostname file exists.

The mdns hostname file being handled by [1] MCO PR.

[1] openshift/machine-config-operator#1446
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1790823, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected Bugzilla bug 1790823 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1790823: Consider mdns hostname file existence in utils.ShortHostname

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 13, 2020
@celebdor
Copy link
Contributor

celebdor commented Feb 13, 2020

/retitle [release-4.3] Bug 1802675: Consider mdns hostname file existence in utils.ShortHostname

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1790823: Consider mdns hostname file existence in utils.ShortHostname [release-4.3] Bug 1802675: Consider mdns hostname file existence in utils.ShortHostname Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1802675, which is invalid:

  • expected dependent Bugzilla bug 1790823 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1802675: Consider mdns hostname file existence in utils.ShortHostname

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yboaron
Copy link
Contributor

yboaron commented Feb 19, 2020

/lgtm

@bparees
Copy link

bparees commented Feb 19, 2020

https://bugzilla.redhat.com/show_bug.cgi?id=1790823 is not yet verified against 4.4 so this can't be cherry pick approved yet

@eparis
Copy link
Member

eparis commented Feb 25, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 25, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 25, 2020

@eparis: This pull request references Bugzilla bug 1802675, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cybertron
cybertron approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cybertron
cybertron reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, hold on, this needs a backport of openshift/machine-config-operator#1455 to land first, right?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@cybertron
Copy link
Member

cybertron commented Feb 25, 2020

The backport is here: openshift/machine-config-operator#1479

I believe we need to wait this one on that PR.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@cybertron
Copy link
Member

cybertron commented Feb 25, 2020

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2020
@eparis
Copy link
Member

eparis commented Feb 26, 2020

It appears the referenced MCO pr (1479) merged.

@cybertron
Copy link
Member

cybertron commented Mar 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 4, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, openshift-cherrypick-robot, yboaron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yboaron yboaron requested a review from cybertron March 4, 2020 15:16
@cybertron cybertron added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 1ba567f into openshift:release-4.3 Mar 4, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 4, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1802675 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.3] Bug 1802675: Consider mdns hostname file existence in utils.ShortHostname

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcrochet bcrochet Awaiting requested review from bcrochet

@cybertron cybertron Awaiting requested review from cybertron

Assignees

@celebdor celebdor

@cybertron cybertron

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @openshift-ci-robot @celebdor @yboaron @bparees @eparis @cybertron @openshift-merge-robot @yboaronn