Skip to content

Bug 1790823: Consider mdns hostname file existence in utils.ShortHostname #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 13, 2020
Merged

Bug 1790823: Consider mdns hostname file existence in utils.ShortHostname #44

openshift-merge-robot merged 1 commit into from
Feb 13, 2020

Conversation

@yboaron
Copy link
Contributor

@yboaron yboaron commented Feb 9, 2020

The utils.ShortHostname function should read hostname from mdns
hostname, if mdns hostname file exists.

This mdns hostname file creation is handled by [1] MCO PR.

[1] https://github.com/openshift/machine-config-operator/pull/1446crea

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 9, 2020
@yboaron
Copy link
Contributor Author

yboaron commented Feb 9, 2020

/cc @celebdor @cybertron @bcrochet

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2020
@celebdor
Copy link
Contributor

celebdor commented Feb 10, 2020

@yboaron needs to be tied to the same bug as openshift/machine-config-operator#1446 (both in bugzilla and here in the title of the PR

celebdor
celebdor requested changes Feb 10, 2020
View reviewed changes
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 10, 2020
@yboaron yboaron changed the title Consider mdns hostname file existence in utils.ShortHostname Bug 1790823: Consider mdns hostname file existence in utils.ShortHostname Feb 10, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2020

@yboaron: This pull request references Bugzilla bug 1790823, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1790823: Consider mdns hostname file existence in utils.ShortHostname

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 10, 2020
@yboaron yboaron requested a review from celebdor February 11, 2020 11:21
@celebdor celebdor mentioned this pull request Feb 12, 2020
Merged
celebdor
celebdor requested changes Feb 12, 2020
View reviewed changes
@yboaronn
Consider mdns hostname file existence in utils.ShortHostname
69d174b 
The utils.ShortHostname function should read hostname from mdns
hostname (/etc/mdns/hostname), if mdns hostname file exists.

The mdns hostname file being handled by [1] MCO PR.

[1] openshift/machine-config-operator#1446
@yboaron yboaron requested a review from celebdor February 13, 2020 10:55
@celebdor
Copy link
Contributor

celebdor commented Feb 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celebdor, yboaron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d150c7d into openshift:master Feb 13, 2020
@celebdor
Copy link
Contributor

celebdor commented Feb 13, 2020

/cherry-pick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 13, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Feb 13, 2020

@celebdor: new pull request created: #45

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre mandre mentioned this pull request Sep 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celebdor celebdor celebdor approved these changes

@cybertron cybertron Awaiting requested review from cybertron

@bcrochet bcrochet Awaiting requested review from bcrochet

Assignees

@celebdor celebdor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yboaron @celebdor @openshift-ci-robot @openshift-cherrypick-robot @openshift-merge-robot @yboaronn