-
Notifications
You must be signed in to change notification settings - Fork 462
Bug 1790823: [baremetal] Verify that MDNS doesn't advertise localhost #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MDNS publisher static pod should start advertising the node only after node's hostname was set by DHCP. The idea is to add an init container that will monitor host's hostname until hostname != localhost. The issue was how host's hostname should be retrieved by the init container. Since the MDNS static pod doesn't use host's uts namespace, reading 'hostname' is not an option. Reading hostname using dbus didn't work due to security constraints(SElinux). The suggested solution composed of: 1. NM dispatcher script will monitor & store hostname in a file 2. Init container will mount this file, and read the value
|
@yboaron: This pull request references Bugzilla bug 1790823, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This PR replaced #1446 |
|
/approve |
|
We need to first merge openshift/baremetal-runtimecfg#44 |
|
/lgtm |
|
/retest |
|
/skip e2e-aws-scaleup-rhel7 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, sinnykumari, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@yboaron: Bugzilla bug 1790823 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@yboaron: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.3 |
|
@celebdor: #1455 failed to apply on top of branch "release-4.3": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
MDNS publisher static pod should start advertising the node only after node's hostname was set by DHCP. The idea is to add an init container that will monitor host's hostname until hostname != localhost. The issue was how host's hostname should be retrieved by the init container. Since the MDNS static pod doesn't use host's uts namespace, reading 'hostname' is not an option. Reading hostname using dbus didn't work due to security constraints(SElinux). The suggested solution composed of: 1. NM dispatcher script will monitor & store hostname in a file 2. Init container will mount this file, and read the value This ports the BM change openshift#1455 to OpenStack platform.
MDNS publisher static pod should start advertising the node only after node's hostname was set by DHCP. The idea is to add an init container that will monitor host's hostname until hostname != localhost. The issue was how host's hostname should be retrieved by the init container. Since the MDNS static pod doesn't use host's uts namespace, reading 'hostname' is not an option. Reading hostname using dbus didn't work due to security constraints(SElinux). The suggested solution composed of: 1. NM dispatcher script will monitor & store hostname in a file 2. Init container will mount this file, and read the value This ports the BM change openshift#1455 to OpenStack platform.
MDNS publisher static pod should start advertising the node
only after node's hostname was set by DHCP.
The idea is to add an init container that will monitor host's hostname
until hostname != localhost.
The issue was how host's hostname should be retrieved by the init container.
Since the MDNS static pod doesn't use host's uts namespace, reading 'hostname'
is not an option.
Reading hostname using dbus didn't work due to security constraints(SElinux).
The suggested solution composed of:
This PR is instead of #1446
- What I did
- How to verify it
- Description for the changelog