Set bmh 'name' in metadata as hostname

[kashifest]

This will set 'name' field of metaData as bmh name, otherwise by default ironic name gets set as hostname by default and ~ in hostname seems to be problematic for kubeadm during cloudinit nodeRegistration.

[kashifest]

/test-v1a3-integration

[hardys]

/cc @asalkeld @zaneb

[kashifest]

To be exact, this is the issue we are facing in v1a3 CI . We dont see it in normal integration (v1a4) since in that case the node name is taken from data template:

nodeRegistration.name: Invalid value: "metal3~node-1": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

[kashifest]

/test-integration
/test-v1a3-centos-integration
/test-centos-integration

[kashifest]

/test-integration
/test-v1a3-integration

[kashifest]

/test-v1a3-integration

[zaneb]

How is the ironic node name getting used as the hostname anyway? If we can find a way to stop that it would be preferable.

[zaneb]

This is unsafe; if we are going to change it, it must be to . not -.

[hardys]

How is the ironic node name getting used as the hostname anyway? If we can find a way to stop that it would be preferable.

I thought the same thing - in the metadata we're setting e.g p.host.ObjectMeta.Name which is the BMH name, not the name in Ironic, right? @dtantsur does Ironic inject the Ironic name in addition to the meta_data.json?

[hardys]

How is the ironic node name getting used as the hostname anyway? If we can find a way to stop that it would be preferable.

I thought the same thing - in the metadata we're setting e.g p.host.ObjectMeta.Name which is the BMH name, not the name in Ironic, right? @dtantsur does Ironic inject the Ironic name in addition to the meta_data.json?

The answer appears to be yes, so this name change isn't as "internal" as we originally envisaged - it seems Ironic injects name in addition to the keys we create in BMO, and presumably cloud-init uses that to set the hostname...

# cat /mnt/openstack/latest/meta_data.json  | jq .
{
  "local-hostname": "ostest-worker-2",
  "local_hostname": "ostest-worker-2",
  "metal3-name": "ostest-worker-2",
  "metal3-namespace": "openshift-machine-api",
  "uuid": "c0fd5a6b-2a7c-46c1-8000-d11b0dc0d8b8",
  "name": "openshift-machine-api~ostest-worker-2"
}

(this is from an openshift environment running the latest BMO)

[zaneb]

The answer appears to be yes, so this name change isn't as "internal" as we originally envisaged - it seems Ironic injects name in addition to the keys we create in BMO, and presumably cloud-init uses that to set the hostname...

It's done using setdefault(), so if we set the name field explicitly in the metadata, that will resolve the problem.

[kashifest]

/test-integration
/test-v1a3-integration

[zaneb]

/lgtm

[kashifest]

Thanks @zaneb that seems to work. Tests have passed now.

[kashifest]

Thanks @hardys for your insight.

[asalkeld]

/lgtm
/approve

[metal3-io-bot]

@asalkeld: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maelk]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asalkeld, kashifest, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [maelk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment