Skip to content

SPLAT-2072: Removed VSphereMultiVCenters feature gate #2231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
May 6, 2025
Merged

SPLAT-2072: Removed VSphereMultiVCenters feature gate #2231

openshift-merge-bot merged 1 commit into from
May 6, 2025

Conversation

@vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Mar 13, 2025 •
edited
Loading

SPLAT-2072

Changes

  • Removed the VSphereMultiVCenter feature gate
  • Updated CRD to allow multiple vCenters always

Dependencies

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2072

Changes

  • Removed the VSphereMultiVCenter feature gate
  • Updated CRD to allow multiple vCenters always

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2025

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 13, 2025
@vr4manta
Copy link
Contributor Author

vr4manta commented Mar 13, 2025

/hold
Waiting for other PRs to finish merging

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.

In response to this:

SPLAT-2072

Changes

  • Removed the VSphereMultiVCenter feature gate
  • Updated CRD to allow multiple vCenters always

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

vr4manta commented Apr 15, 2025

/retest-required
/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2025
@jcpowermac
Copy link
Contributor

jcpowermac commented Apr 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
@jcpowermac
Copy link
Contributor

jcpowermac commented Apr 16, 2025

/lgtm

@vr4manta
Copy link
Contributor Author

vr4manta commented Apr 16, 2025

/assign @JoelSpeed

@vr4manta
Copy link
Contributor Author

vr4manta commented Apr 21, 2025

The past several days tests have been failing due to aws lease issues (too many). I'll try a few more times, but I am not sure these failing jobs matter for the vSphere api featuregate cleanup.

@vr4manta
Copy link
Contributor Author

vr4manta commented Apr 21, 2025

/retest-required

1 similar comment
@vr4manta
Copy link
Contributor Author

vr4manta commented Apr 22, 2025

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Apr 24, 2025

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2025

/retest-required

Remaining retests: 0 against base HEAD 1ee228b and 2 for PR HEAD ad9f718 in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 24, 2025

/retest-required

Remaining retests: 0 against base HEAD 1ee228b and 2 for PR HEAD ad9f718 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2025

/retest-required

Remaining retests: 0 against base HEAD 18bb3d9 and 1 for PR HEAD ad9f718 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2025

/retest-required

Remaining retests: 0 against base HEAD 9b80d67 and 2 for PR HEAD ad9f718 in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2025

/retest-required

Remaining retests: 0 against base HEAD 9b80d67 and 2 for PR HEAD ad9f718 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 26, 2025

/retest-required

Remaining retests: 0 against base HEAD e577b4d and 1 for PR HEAD ad9f718 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 28, 2025

/retest-required

Remaining retests: 0 against base HEAD e577b4d and 2 for PR HEAD ad9f718 in total

@vr4manta
Copy link
Contributor Author

vr4manta commented Apr 28, 2025

I'll take a look at why verify is now failing. Looks like regen required.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 28, 2025

/retest-required

Remaining retests: 0 against base HEAD e577b4d and 2 for PR HEAD ad9f718 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2025
@rvanderp3
Copy link
Contributor

rvanderp3 commented Apr 30, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, JoelSpeed, rvanderp3, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vr4manta
Copy link
Contributor Author

vr4manta commented Apr 30, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Apr 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2025

/retest-required

Remaining retests: 0 against base HEAD fb1b1c7 and 2 for PR HEAD 31cf428 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2025

/retest-required

Remaining retests: 0 against base HEAD d22fca8 and 1 for PR HEAD 31cf428 in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 1, 2025

/retest-required

Remaining retests: 0 against base HEAD d22fca8 and 2 for PR HEAD 31cf428 in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 1, 2025

/retest-required

Remaining retests: 0 against base HEAD d22fca8 and 2 for PR HEAD 31cf428 in total

@JoelSpeed
Copy link
Contributor

JoelSpeed commented May 2, 2025

/override ci/prow/e2e-aws-serial

Test suite passed, but hit a timeout right at the end. This gate removal should have no effect on AWS testing anyway

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2025

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial

In response to this:

/override ci/prow/e2e-aws-serial

Test suite passed, but hit a timeout right at the end. This gate removal should have no effect on AWS testing anyway

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2025

/retest-required

Remaining retests: 0 against base HEAD 7152b1b and 2 for PR HEAD 31cf428 in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 5, 2025

/retest-required

Remaining retests: 0 against base HEAD 7152b1b and 2 for PR HEAD 31cf428 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2025 •
edited
Loading

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 31cf428 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025

/retest-required

Remaining retests: 0 against base HEAD 7152b1b and 2 for PR HEAD 31cf428 in total

@openshift-merge-bot openshift-merge-bot bot merged commit ec925ab into openshift:master May 6, 2025
23 of 24 checks passed
@openshift-bot
Copy link

openshift-bot commented May 6, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202505062056.p0.gec925ab.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@jcpowermac jcpowermac

@JoelSpeed JoelSpeed

@rvanderp3 rvanderp3

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vr4manta @openshift-ci-robot @jcpowermac @JoelSpeed @rvanderp3 @openshift-bot