Skip to content

SPLAT-2072: Removed VSphereMultiVCenters feature gate#300

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
vr4manta:SPLAT-2072
Apr 15, 2025
Merged

SPLAT-2072: Removed VSphereMultiVCenters feature gate#300
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
vr4manta:SPLAT-2072

Conversation

@vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Mar 18, 2025

SPLAT-2072

Changes

  • Removed usage of VSphereMultiVCenters feature gate
  • Migrated multivcenterstorageclasscontroller into the default controller

Notes

After a feature gate has been GA in an OCP release, we are supposed to clean up feature gate usage in the next release. VSphere multi vCenter support GA'd in 4.18, so the intention is to remove the feature gate as part of 4.19.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 18, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 18, 2025

@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

SPLAT-2072

Changes

  • Removed usage of VSphereControlPlaneMachineset feature gate
  • Migrated multivcenterstorageclasscontroller into the default controller

Notes

After a feature gate has been GA in an OCP release, we are supposed to clean up feature gate usage in the next release. VSphere multi vCenter support GA'd in 4.18, so the intention is to remove the feature gate as part of 4.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 18, 2025

@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

SPLAT-2072

Changes

  • Removed usage of VSphereControlPlaneMachineset feature gate
  • Migrated multivcenterstorageclasscontroller into the default controller

Notes

After a feature gate has been GA in an OCP release, we are supposed to clean up feature gate usage in the next release. VSphere multi vCenter support GA'd in 4.18, so the intention is to remove the feature gate as part of 4.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta vr4manta force-pushed the SPLAT-2072 branch 2 times, most recently from 318069a to b0d42b0 Compare March 18, 2025 21:27
@vr4manta
Copy link
Contributor Author

/test all

@vr4manta
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 19, 2025

@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta vr4manta marked this pull request as ready for review March 19, 2025 13:44
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2025
@openshift-ci openshift-ci bot requested review from mpatlasov and tsmetana March 19, 2025 13:55
@vr4manta
Copy link
Contributor Author

/assign @gnufied

@vr4manta vr4manta changed the title SPLAT-2072: Removed VSphereControlPlaneMachineset feature gate SPLAT-2072: Removed VSphereMultiVCenters feature gate Apr 1, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2025

@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.

Details

In response to this:

SPLAT-2072

Changes

  • Removed usage of VSphereMultiVCenters feature gate
  • Migrated multivcenterstorageclasscontroller into the default controller

Notes

After a feature gate has been GA in an OCP release, we are supposed to clean up feature gate usage in the next release. VSphere multi vCenter support GA'd in 4.18, so the intention is to remove the feature gate as part of 4.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

vr4manta commented Apr 2, 2025

/retest

@vr4manta
Copy link
Contributor Author

vr4manta commented Apr 7, 2025

@gnufied I've pushed changes and am ready for re-review. Thanks!

@gnufied
Copy link
Member

gnufied commented Apr 10, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@rvanderp3
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@duanwei33
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 15, 2025

@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.

Details

In response to this:

SPLAT-2072

Changes

  • Removed usage of VSphereMultiVCenters feature gate
  • Migrated multivcenterstorageclasscontroller into the default controller

Notes

After a feature gate has been GA in an OCP release, we are supposed to clean up feature gate usage in the next release. VSphere multi vCenter support GA'd in 4.18, so the intention is to remove the feature gate as part of 4.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@duanwei33
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 15, 2025

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 9483f9d link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 290f27c into openshift:main Apr 15, 2025
13 of 14 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-vmware-vsphere-csi-driver-operator
This PR has been included in build ose-vmware-vsphere-csi-driver-operator-container-v4.20.0-202504151644.p0.g290f27c.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants