Skip to content

Conversation

@vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Mar 11, 2025

SPLAT-2072

Changes

  • Removed usage of feature gate VSphereMultiVCenter for multiple vCenter configurations since its now GA.
  • Removed legacy ini configuration from installer now that multi vCenter is GA.

Notes

After a feature gate has been GA in an OCP release, we are supposed to clean up feature gate usage in the next release. Multi vCenter support GA'd in 4.18, so the intention is to remove the feature gate as part of 4.19.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 11, 2025

@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

SPLAT-2072

Changes

  • Removed usage of feature gate VSphereMultiVCenter for multiple vCenter configurations since its now GA.
  • Removed legacy ini configuration from installer now that multi vCenter is GA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jcpowermac and rna-afk March 11, 2025 15:15
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 11, 2025

@vr4manta: This pull request references SPLAT-2072 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

SPLAT-2072

Changes

  • Removed usage of feature gate VSphereMultiVCenter for multiple vCenter configurations since its now GA.
  • Removed legacy ini configuration from installer now that multi vCenter is GA.

Notes

After a feature gate has been GA in an OCP release, we are supposed to clean up feature gate usage in the next release. Multi vCenter support GA'd in 4.18, so the intention is to remove the feature gate as part of 4.19.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Member

tthvo commented Mar 11, 2025

/retest

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Just waiting for infra to run tests, but LGTM otherwise 😃

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2025
@vr4manta
Copy link
Contributor Author

/retest-required

@sadasu
Copy link
Contributor

sadasu commented Mar 14, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 73b3903 and 2 for PR HEAD 49fd758 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 73b3903 and 2 for PR HEAD 49fd758 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 49fd758 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tthvo
Copy link
Member

tthvo commented Mar 14, 2025

/override ci/prow/okd-scos-images
/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@tthvo: Overrode contexts on behalf of tthvo: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 656783f into openshift:main Mar 15, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants