AGENT-1302: Read template from .template path#156
AGENT-1302: Read template from .template path#156openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
Expect to read the rendezvous-host.env template from a separate .template file. The template is placed there by openshift/installer#9941. Only fall back to expecting the .env file to be a template if the former is not present. This change is backward-compatible.
openshift-ci-robot
added
the
jira/valid-reference
|
@zaneb: This pull request references AGENT-1302 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Test is blocked by openshift/appliance#543 |
|
/retest |
|
Let's try again with openshift/appliance#545 |
|
/retest |
|
/lgtm |
|
No regression. |
openshift-ci-robot
added
the
verified
|
@zaneb: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@zaneb: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Expect to read the rendezvous-host.env template from a separate .template file. The template is placed there by
openshift/installer#9941.
Only fall back to expecting the .env file to be a template if the former is not present. This change is backward-compatible.