Skip to content

MGMT-21882: parse all the idms file entries when generating the RegistriesConf asset#545

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
andfasano:fix-registriesconf-parse-all-entries
Oct 2, 2025
Merged

MGMT-21882: parse all the idms file entries when generating the RegistriesConf asset#545
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
andfasano:fix-registriesconf-parse-all-entries

Conversation

@andfasano
Copy link
Contributor

This patch addresses the issue related to the execution of the OpenShift CI e2e-agent-iso-no-registry-compact-ipv4 jobs, by reviewing the parsing logic of the RegistriesConf asset to include all the entries found in the idms file produced by oc-mirror

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 30, 2025

@andfasano: This pull request references MGMT-21882 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This patch addresses the issue related to the execution of the OpenShift CI e2e-agent-iso-no-registry-compact-ipv4 jobs, by reviewing the parsing logic of the RegistriesConf asset to include all the entries found in the idms file produced by oc-mirror

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2025
@andfasano
Copy link
Contributor Author

/assign @danielerez

@openshift-ci openshift-ci bot requested review from jhernand and oourfali September 30, 2025 17:43
@andfasano andfasano changed the title [WIP] MGMT-21882: parse all the idms file entries when generating the RegistriesConf asset MGMT-21882: parse all the idms file entries when generating the RegistriesConf asset Oct 1, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2025
@andfasano
Copy link
Contributor Author

@danielerez from a local test it looks like the registries.conf is generated correctly

@bfournie
Copy link

bfournie commented Oct 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
@danielerez
Copy link
Contributor

/approved

@danielerez
Copy link
Contributor

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2025

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danielerez
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, danielerez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 5a13726 into openshift:master Oct 2, 2025
8 checks passed
andfasano added a commit to andfasano/appliance that referenced this pull request Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants