MGMT-21882: parse all the idms file entries when generating the RegistriesConf asset#545
Conversation
|
@andfasano: This pull request references MGMT-21882 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @danielerez |
|
@danielerez from a local test it looks like the registries.conf is generated correctly |
|
/lgtm |
|
/approved |
|
/retest |
|
@andfasano: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, danielerez The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch addresses the issue related to the execution of the OpenShift CI e2e-agent-iso-no-registry-compact-ipv4 jobs, by reviewing the parsing logic of the RegistriesConf asset to include all the entries found in the idms file produced by oc-mirror