MGMT-21854: fix registries.conf generation for multiple yaml mirror files#543
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@andfasano: This pull request references MGMT-21854 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @danielerez |
|
/lgtm |
pkg/asset/registry/registriesconf.go
Outdated
| for _, digestMirrors := range idms.Spec.ImageDigestMirrors { | ||
| if len(digestMirrors.Mirrors) == 0 { | ||
| continue | ||
| dec := yaml.NewDecoder(bytes.NewReader(idmsFile)) |
There was a problem hiding this comment.
For consistency/readability, maybe we could use the generic GetMultipleYamls func instead?
See for example usage in:
There was a problem hiding this comment.
Good idea @danielerez , didn't spot that GetMultipleYamls was available. Done
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, danielerez The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@andfasano: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
…iles (openshift#543) * fix registries.conf generation for multiple yaml mirror files * use GetMultipleYamls for manifests parsing
4 participants
Currently the Prow CI OVE ISO jobs are permafailing due the incorrect parsing of the oc-mirror generated files. This patch fixes the issue by enabling the parsing of multi-doc yaml files for the RegistriesConf asset.