Skip to content

OCPBUGS-59724: add back NHR and FAR operators#130

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
andfasano:fix-add-back-nhr-far-operators
Jul 23, 2025
Merged

OCPBUGS-59724: add back NHR and FAR operators#130
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
andfasano:fix-add-back-nhr-far-operators

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Jul 23, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2025

@andfasano: This pull request references Jira Issue OCPBUGS-59724, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This patch partially reverts #117 to reintroduce in the supported list both the NHR and FAR OLM operators

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano
Copy link
Contributor Author

andfasano commented Jul 23, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 23, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2025

@andfasano: This pull request references Jira Issue OCPBUGS-59724, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

Details

In response to this:

This patch partially reverts #117 to reintroduce in the supported list both the NHR and FAR OLM operators

Related to:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2025

@andfasano: This pull request references Jira Issue OCPBUGS-59724, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from bfournie, celebdor and mhanss July 23, 2025 14:41
@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2025
@andfasano
Copy link
Contributor Author

andfasano commented Jul 23, 2025

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 23, 2025

@andfasano: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rwsu
rwsu reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 81c4340 into openshift:main Jul 23, 2025
12 of 14 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2025

@andfasano: Jira Issue OCPBUGS-59724: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-59724 has been moved to the MODIFIED state.

Details

In response to this:

This patch partially reverts #117 to reintroduce in the supported list both the NHR and FAR OLM operators

Related to:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2025

@andfasano: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-iso-no-registry-compact-ipv4 03b0745 link false /test e2e-agent-iso-no-registry-compact-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jul 23, 2025

@andfasano: new pull request created: #131

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 23, 2025
Merged
@openshift-bot
Copy link

openshift-bot commented Jul 24, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-utils
This PR has been included in build ose-agent-installer-utils-container-v4.20.0-202507240213.p0.g81c4340.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhanss mhanss Awaiting requested review from mhanss

@bfournie bfournie Awaiting requested review from bfournie

@celebdor celebdor Awaiting requested review from celebdor

1 more reviewer

@rwsu rwsu rwsu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@rwsu rwsu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andfasano @openshift-ci-robot @openshift-cherrypick-robot @openshift-bot @rwsu