Revert "MGMT-20893: Remove Remediation operators " - Add Node Health Check and Fence Agents Remediation operators

[ammont82]

This reverts commit c80ced4.

Summary by CodeRabbit

• New Features

  • Introduced a new "Remediation" category for operators.
  • Added "Node Healthcheck" and "Fence Agents Remediation" operators under the "Remediation" category, each with detailed descriptions and support information.

• Other Changes

  • Expanded operator categories to include "Remediation" and "Other".
  • The list of supported operators now includes all operators provided by the API, without internal filtering.

[openshift-ci-robot]

@ammont82: This pull request references MGMT-20893 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This reverts commit c80ced4.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

This update adds a new "Remediation" category to the operator specifications and introduces two new operators under it: "Node Healthcheck" and "Fence Agents Remediation." It also extends the Category enum and categories mapping accordingly. Additionally, the OperatorsService now returns the full list of operators from the API without filtering against known operator keys.

Changes

File(s)	Change Summary
libs/ui-lib/lib/common/components/operators/operatorSpecs.tsx	Added "Remediation" and "Other" to Category enum and categories mapping; introduced two new remediation operators.
libs/ui-lib/lib/ocm/services/OperatorsService.tsx	Removed filtering of operators by known keys; now returns all operators from the API directly.

Sequence Diagram(s)

sequenceDiagram
    participant UI
    participant OperatorsService
    participant API

    UI->>OperatorsService: getSupportedOperators()
    OperatorsService->>API: fetch operators list
    API-->>OperatorsService: return all operators
    OperatorsService-->>UI: return unfiltered operator list

Loading

Estimated code review effort

2 (~12 minutes)

Possibly related PRs

• MGMT-20483: Adding new categories for operators #3018: Both PRs modify operatorSpecs.tsx to update the Category enum and categories mapping, directly relating to operator categorization.
• OCPBUGS-58156: Remove operators from OVE UI #3021: This PR adds, while OCPBUGS-58156: Remove operators from OVE UI #3021 removes, the same remediation operators, showing a direct but opposite relationship.
• MGMT-20893: Remove Remediation operators #3014: This PR adds, while MGMT-20893: Remove Remediation operators #3014 removes, the "Remediation" category and its operators, making their changes directly opposite.

Suggested labels

lgtm

Suggested reviewers

• rawagner
• celdrake

Poem

In the warren of code so neat,
New operators hop in with nimble feet.
Remediation arrives, with healthchecks in tow,
Fence Agents too, in the UI they show.
No more filtering—let all operators play,
The rabbit approves this update today! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

libs/ui-lib/lib/common/components/operators/operatorSpecs.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct.

The config "@openshift-assisted/eslint-config" was referenced from the config file in "/libs/ui-lib/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

libs/ui-lib/lib/ocm/services/OperatorsService.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct.

The config "@openshift-assisted/eslint-config" was referenced from the config file in "/libs/ui-lib/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eaa6434 and 085a886.

📒 Files selected for processing (2)

• libs/ui-lib/lib/common/components/operators/operatorSpecs.tsx (6 hunks)
• libs/ui-lib/lib/ocm/services/OperatorsService.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• libs/ui-lib/lib/ocm/services/OperatorsService.tsx
• libs/ui-lib/lib/common/components/operators/operatorSpecs.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: circular-deps
• GitHub Check: translation-files
• GitHub Check: tests
• GitHub Check: unit-tests
• GitHub Check: lint
• GitHub Check: format

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ammont82]

/cherry-pick releases/v2.43

[openshift-cherrypick-robot]

@ammont82: once the present PR merges, I will cherry-pick it on top of releases/v2.43 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick releases/v2.43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@ammont82: This pull request references MGMT-20893 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This reverts commit c80ced4.

Summary by CodeRabbit

• New Features

• Introduced a new "Remediation" category for operators.

• Added "Node Healthcheck" and "Fence Agents Remediation" operators under the "Remediation" category, each with detailed descriptions and support information.

• Other Changes

• Expanded operator categories to include "Remediation" and "Other".

• The list of supported operators now includes all operators provided by the API, without internal filtering.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ammont82: This pull request references MGMT-20893 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This reverts commit c80ced4.

Summary by CodeRabbit

• New Features

• Introduced a new "Remediation" category for operators.

• Added "Node Healthcheck" and "Fence Agents Remediation" operators under the "Remediation" category, each with detailed descriptions and support information.

• Other Changes

• Expanded operator categories to include "Remediation" and "Other".

• The list of supported operators now includes all operators provided by the API, without internal filtering.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, celdrake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ammont82,celdrake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@ammont82: new pull request created: #3064

Details

In response to this:

/cherry-pick releases/v2.43

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.