Revert "OCPBUGS-58156: Remove operators from OVE UI"

[ammont82]

This reverts commit e4fb5df.

Add Node Health Check and Fence Agents Remediation operators to OVE

Summary by CodeRabbit

• New Features
  • Expanded support for single cluster operators by recognizing two additional operator types.

[openshift-ci-robot]

@ammont82: This pull request references Jira Issue OCPBUGS-58156, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This reverts commit e4fb5df.

Add Node Health Check and Fence Agents Remediation operators to OVE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Two operator constants, OPERATOR_NAME_NODE_HEALTHCHECK and OPERATOR_NAME_FENCE_AGENTS_REMEDIATION, were added to the singleClusterOperators array in the constants configuration file. No changes were made to exported or public entity declarations; only the array's contents were updated.

Changes

File(s)	Change Summary
libs/ui-lib/lib/common/config/constants.ts	Added two operator constants to the singleClusterOperators array.

Estimated code review effort

1 (~2 minutes)

Possibly related PRs

• OCPBUGS-58156: Remove operators from OVE UI #3021: Removes the same operators from the singleClusterOperators array, directly modifying the same code elements in the opposite way.
• Update list of ABI operators #2947: Rearranges and removes operators in the same array, indicating related changes focused on the singleClusterOperators array.

Suggested labels

lgtm, approved, size/XS

Poem

Two new operators hop in the line,
Node health and fence agents, both doing fine.
Constants array grows, a simple delight,
The cluster’s more ready, all through the night.
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

libs/ui-lib/lib/common/config/constants.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@openshift-assisted/eslint-config" to extend from. Please check that the name of the config is correct.

The config "@openshift-assisted/eslint-config" was referenced from the config file in "/libs/ui-lib/.eslintrc.cjs".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae1d05a and cc7e445.

📒 Files selected for processing (1)

• libs/ui-lib/lib/common/config/constants.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: unit-tests
• GitHub Check: circular-deps
• GitHub Check: tests
• GitHub Check: translation-files
• GitHub Check: lint
• GitHub Check: format

🔇 Additional comments (1)

libs/ui-lib/lib/common/config/constants.ts (1)

334-336: LGTM! Clean revert of operator removals.

The revert correctly adds back the Node Health Check and Fence Agents Remediation operators to the singleClusterOperators array. Both constants are properly defined earlier in the file and the changes align with the PR objective of reverting the previous removal.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ammont82]

/cherry-pick release-4.19

[openshift-cherrypick-robot]

@ammont82: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ammont82, celdrake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ammont82,celdrake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@ammont82: Jira Issue OCPBUGS-58156 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

Details

In response to this:

This reverts commit e4fb5df.

Add Node Health Check and Fence Agents Remediation operators to OVE

Summary by CodeRabbit

• New Features
• Expanded support for single cluster operators by recognizing two additional operator types.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@ammont82: new pull request created: #3063

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ammont82]

/cherry-pick release-4.20

[openshift-cherrypick-robot]

@ammont82: new pull request could not be created: failed to create pull request against openshift-assisted/assisted-installer-ui#release-4.20 from head openshift-cherrypick-robot:cherry-pick-3062-to-release-4.20: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift-assisted:release-4.20 and openshift-cherrypick-robot:cherry-pick-3062-to-release-4.20"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.