vSphere IPI: Enable thin provisioning via the OVA import by jcpowermac · Pull Request #4664 · openshift/installer

jcpowermac · 2021-02-17T17:20:44Z

This PR enables thin provisioning via the importing process
of the RHCOS ova. Terraform will then clone the virtual machine
based on the existing template disk type.

This adds an additional option in the vsphere platform struct Thin.

Performance testing needs to be completed before offering this as an option
Virtual machine provisioning with storage options can be problematic, additional testing in a nested environment is required.

openshift-ci-robot · 2021-02-17T17:20:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sdodson after the PR has been reviewed.
You can assign the PR to them by writing /assign @sdodson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jcpowermac · 2021-02-17T17:26:36Z

/test e2e-vsphere

mtnbikenc · 2021-04-22T15:34:28Z

/uncc

jcpowermac · 2021-07-12T16:50:44Z

The performance testing has been done for a while:
https://github.com/jcpowermac/etcd-thin-vs-thick-perf-test/tree/main/results
No major difference between think and thin provisioning.

jcpowermac · 2021-08-06T17:49:36Z

/test e2e-vsphere
/test e2e-vsphere-upi

ayesha54 · 2021-09-28T18:15:33Z

/test e2e-vsphere
/test e2e-vsphere-upi

ayesha54 · 2021-09-28T18:19:47Z

/assign @staebler
/assign @jstuever

ayesha54 · 2021-09-28T18:21:41Z

/unassign @staebler
/unassign @jstuever

jcpowermac · 2021-11-08T20:49:29Z

@ayesha54 can you fix codegen and we should be able to get this merged

jcpowermac · 2021-11-09T14:34:08Z

/test e2e-vsphere

jcpowermac · 2021-11-09T16:06:24Z

The cluster installed correctly. 503 issues with vCenter APIs - unreleated to PR.
lgtm

rvanderp3 · 2021-11-09T16:28:45Z

/test e2e-vsphere

rvanderp3 · 2021-11-09T16:31:02Z

/test e2e-vsphere

Just kicked this off, as jcallen mentioned, last fail doesn't appear to be related to this PR.

rvanderp3 · 2021-11-09T17:03:54Z

/lgtm

jstuever · 2021-11-09T17:09:05Z

/test e2e-vsphere

jstuever · 2021-11-09T17:09:50Z

/hold for e2e-vsphere

jstuever · 2021-11-09T17:11:53Z

/lgtm
/approve

openshift-ci · 2021-11-09T17:13:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jstuever]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2021-11-09T18:35:26Z

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-byon	d6967825544a0c4ca692fa1db541084bb3db5421	link	`/test e2e-openstack-byon`
ci/prow/e2e-vsphere-upi	d6967825544a0c4ca692fa1db541084bb3db5421	link	false	`/test e2e-vsphere-upi`
ci/prow/e2e-aws-workers-rhel8	`b06e405`	link	false	`/test e2e-aws-workers-rhel8`
ci/prow/e2e-aws-workers-rhel7	`b06e405`	link	false	`/test e2e-aws-workers-rhel7`
ci/prow/e2e-aws-fips	`b06e405`	link	false	`/test e2e-aws-fips`
ci/prow/e2e-aws-single-node	`b06e405`	link	false	`/test e2e-aws-single-node`
ci/prow/e2e-metal-single-node-live-iso	`b06e405`	link	false	`/test e2e-metal-single-node-live-iso`
ci/prow/okd-e2e-aws-upgrade	`b06e405`	link	false	`/test okd-e2e-aws-upgrade`
ci/prow/e2e-crc	`b06e405`	link	false	`/test e2e-crc`
ci/prow/e2e-metal-ipi-ovn-ipv6	`b06e405`	link	false	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-vsphere	`b06e405`	link	false	`/test e2e-vsphere`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jcpowermac · 2021-11-09T18:37:43Z

@jstuever
vCenter infra issues - unrelated to the pr

event happened 27 times, something is wrong: ns/openshift-machine-api machine/ci-op-vjjfm8lc-67021-lzz57-master-0 - reason/FailedUpdate ci-op-vjjfm8lc-67021-lzz57-master-0: reconciler failed to Update machine: failed to reconcile tags: POST https://vcenter.sddc-44-236-21-251.vmwarevmc.com/rest/com/vmware/cis/session: 503 Service Unavailable

jstuever · 2021-11-09T21:06:07Z

/hold cancel

openshift-bot · 2021-11-09T21:41:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-11-09T23:30:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

In openshift#4664 I incorrectly commented to use `eagerZeroedThick`. The correct disktype to keep the vSphere install the same as previous versions is `thick`. eagerZeroed as named will write zeros when creating the vmdk which significantly extends the time to import and clone virtual machines.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2021

openshift-ci-robot requested review from jstuever and mtnbikenc February 17, 2021 17:20

jcpowermac force-pushed the vsphere_ipi_thin branch from 8065291 to 196a66b Compare February 17, 2021 17:23

jcpowermac commented Feb 17, 2021

View reviewed changes

Comment thread pkg/types/vsphere/platform.go Outdated

staebler reviewed Feb 17, 2021

View reviewed changes

Comment thread pkg/types/vsphere/platform.go Outdated

openshift-ci-robot removed the request for review from mtnbikenc April 22, 2021 15:34

ayesha54 force-pushed the vsphere_ipi_thin branch from 153844b to 196a66b Compare July 15, 2021 21:10

jcpowermac force-pushed the vsphere_ipi_thin branch from b6621d0 to 685f31a Compare August 5, 2021 14:20

jcpowermac commented Aug 5, 2021

View reviewed changes

Comment thread data/data/vsphere/variables-vsphere.tf Outdated

ayesha54 force-pushed the vsphere_ipi_thin branch from 595d08a to 78d1333 Compare August 6, 2021 11:55

ayesha54 force-pushed the vsphere_ipi_thin branch 2 times, most recently from 006c644 to d696782 Compare August 6, 2021 18:08

openshift-ci Bot assigned jstuever and staebler Sep 28, 2021

jcpowermac changed the title ~~[wip] vSphere IPI: Enable thin provisioning via the OVA import~~ vSphere IPI: Enable thin provisioning via the OVA import Sep 28, 2021

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 28, 2021

openshift-ci Bot unassigned jstuever and staebler Sep 28, 2021

ayesha54 force-pushed the vsphere_ipi_thin branch 3 times, most recently from 9b1bba0 to ae2c087 Compare October 4, 2021 14:44

ayesha54 force-pushed the vsphere_ipi_thin branch 3 times, most recently from 90c3776 to 2b02a27 Compare October 20, 2021 12:42

Make Disk Type as Enum for Vpshere

b06e405

ayesha54 force-pushed the vsphere_ipi_thin branch from 2b02a27 to b06e405 Compare November 9, 2021 13:05

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2021

openshift-ci Bot assigned jstuever Nov 9, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2021

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2021

openshift-ci Bot assigned rvanderp3 Nov 9, 2021

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2021

openshift-merge-robot merged commit 18d10c3 into openshift:master Nov 9, 2021

jcpowermac mentioned this pull request Nov 17, 2021

vSphere: Set default disktype to thick not eager #5395

Merged

Conversation

jcpowermac commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 17, 2021

Uh oh!

jcpowermac commented Feb 17, 2021

Uh oh!

Uh oh!

Uh oh!

mtnbikenc commented Apr 22, 2021

Uh oh!

jcpowermac commented Jul 12, 2021

Uh oh!

Uh oh!

jcpowermac commented Aug 6, 2021

Uh oh!

ayesha54 commented Sep 28, 2021

Uh oh!

ayesha54 commented Sep 28, 2021

Uh oh!

ayesha54 commented Sep 28, 2021

Uh oh!

jcpowermac commented Nov 8, 2021

Uh oh!

jcpowermac commented Nov 9, 2021

Uh oh!

jcpowermac commented Nov 9, 2021

Uh oh!

rvanderp3 commented Nov 9, 2021

Uh oh!

rvanderp3 commented Nov 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rvanderp3 commented Nov 9, 2021

Uh oh!

jstuever commented Nov 9, 2021

Uh oh!

jstuever commented Nov 9, 2021

Uh oh!

jstuever commented Nov 9, 2021

Uh oh!

openshift-ci Bot commented Nov 9, 2021

Uh oh!

openshift-ci Bot commented Nov 9, 2021

Uh oh!

jcpowermac commented Nov 9, 2021

Uh oh!

jstuever commented Nov 9, 2021

Uh oh!

openshift-bot commented Nov 9, 2021

Uh oh!

openshift-bot commented Nov 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

jcpowermac commented Feb 17, 2021 •

edited

Loading

rvanderp3 commented Nov 9, 2021 •

edited

Loading