Skip to content

docs: correct spelling in docs#5165

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vbelouso:docs-typo-errors
Nov 10, 2021
Merged

docs: correct spelling in docs#5165
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
vbelouso:docs-typo-errors

Conversation

@vbelouso
Copy link
Copy Markdown

@vbelouso vbelouso commented Aug 22, 2021

Correct spelling to improve the readability of the documentation

@openshift-ci openshift-ci Bot requested review from adduarte and e-tienne August 22, 2021 09:12
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 22, 2021

Hi @vbelouso. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@e-tienne
Copy link
Copy Markdown
Contributor

e-tienne commented Aug 24, 2021

/ok-to-test

e-tienne
e-tienne reviewed Aug 24, 2021
View reviewed changes
Comment thread docs/design/openstack/networking-infrastructure.md Outdated
Copy link
Copy Markdown
Contributor

@e-tienne e-tienne Aug 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the spelling issue here?

Copy link
Copy Markdown
Author

@vbelouso vbelouso Aug 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in word seperate. I'm not sure why the whole block of text is listed in diff and not a specific word.

e-tienne
e-tienne reviewed Aug 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@e-tienne e-tienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spelling corrections look good to me; however I'd like to understand the change in docs/design/openstack/networking-infrastructure.md

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2021
@vbelouso
Copy link
Copy Markdown
Author

vbelouso commented Aug 25, 2021

/retest

@vbelouso
Copy link
Copy Markdown
Author

vbelouso commented Aug 31, 2021

/assign @adduarte

e-tienne
e-tienne reviewed Sep 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@e-tienne e-tienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 26, 2021
docs: correct spelling in docs
51a4034 
Correct spelling to improve the readability of the documentation
@openshift-ci openshift-ci Bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 1, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 1, 2021 •
edited
Loading

@vbelouso: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-unit 7a7be250481349113df258fd67764c82f730b44e link true /test okd-unit
ci/prow/e2e-aws-workers-rhel8 51a4034 link false /test e2e-aws-workers-rhel8

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

staebler
staebler approved these changes Nov 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 10, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 10, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 10, 2021

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 468ace0 into openshift:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adduarte adduarte Awaiting requested review from adduarte

2 more reviewers

@e-tienne e-tienne e-tienne left review comments

@staebler staebler staebler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@staebler staebler

@e-tienne e-tienne

@adduarte adduarte

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vbelouso @e-tienne @openshift-bot @staebler @openshift-merge-robot @adduarte