Set installer release image override when running from source

[hardys]

This was removed in #758 but it turns out the default origin builds
still contain old ironic images, ref discussion on
openshift/ironic-inspector-image#17

It also seems sane to ensure the release image set in dev-scripts is
the same as the installer, which currently is not the case, we're
defaulting to ocp builds and the installer to origin.

Closes: #775

[stbenjam]

I'm really confused, dev-scripts points to registry.svc.ci.openshift.org/ocp/release:4.2

The installer we extract from that release gives us this:

$ ./openshift-baremetal-install version
./openshift-baremetal-install v4.2.0-201908272219-dirty
built from commit 85bda0251b2eb644e1f7a1789311b6ba110930a8
release image registry.svc.ci.openshift.org/ocp/release@sha256:b3097d47ce098c64c835ae29859ccb5d4f04f5a4311bb9b0e0e2fb078c2f001b

The release you extract an image from is baked into the installer; you should not need to set OVERRIDE at all. oc takes care of this because it patches the binary. Are you not seeing this behavior?

If you are doing a source install, we may need to set the OVERRIDE, but certainly not when using images.

[stbenjam]

I think you could move this into the build_installer function - https://github.com/openshift-metal3/dev-scripts/blob/master/ocp_install_env.sh#L71, so it's only set when using source.

[hardys]

Thanks for the feedback @stbenjam - yes this is a source install, will rework so we only set the override in the build_installer function

[stbenjam]

LGTM.