Always use RHCOS version from installer #778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This could be an alternative to #766 |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1109/ |
stbenjam
force-pushed
the
rhcos-from-installer
branch
from
f9f3ce4 to
0df6722
Compare
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1110/ |
stbenjam
force-pushed
the
rhcos-from-installer
branch
from
0df6722 to
2975c76
Compare
stbenjam
changed the title
|
cc @rlopez133 we discussed this approach for install-scripts |
hardys
reviewed
Aug 29, 2019
hardys
reviewed
Aug 29, 2019
|
looks good, we can see the CI pass used the right image: However I think there's a rebase mistake which accidentally reverts #776 ? |
hardys
approved these changes
Aug 29, 2019
hardys
left a comment
hardys
left a comment
There was a problem hiding this comment.
Other than now needing a rebase, and possible optimization of not downloading rhcos.json in the source case (not blocking on that though) lgtm, thanks!
stbenjam
force-pushed
the
rhcos-from-installer
branch
from
2975c76 to
ceb9867
Compare
Instead of hardcoding the RHCOS version in dev-scripts, by re-ordering some things like extracting/building the installer first, we can use the rhcos.json from the installer to find out which RHCOS version we should be using.
stbenjam
force-pushed
the
rhcos-from-installer
branch
from
ceb9867 to
33667e6
Compare
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1112/ |
Member
Author
|
Ready for another look, CI passed and I fixed it so it reads rhcos.json from the git repo if we're doing a source install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding the RHCOS version in dev-scripts, by re-ordering
some things like extracting/building the installer first, we can use the
rhcos.json from the installer to find out which RHCOS version we should
be using.