Extract installer using oc adm release extract
#758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
One of the next nightlies should have an updated |
Contributor
|
Looks great |
stbenjam
force-pushed
the
oc
branch
5 times, most recently
from
0061450 to
3acad7c
Compare
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1082/ |
stbenjam
changed the title
oc adm release extractoc adm release extract
stbenjam
force-pushed
the
oc
branch
2 times, most recently
from
4cfe760 to
32f0f66
Compare
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1096/ |
This changes dev-scripts to use oc adm release extract, which produces an openshift-baremetal-install binary with the release payload set from which it was extracted. This means we no longer need to set OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE.
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1097/ |
Member
Author
|
Updated and CI is passing. Ready for another review. |
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Aug 28, 2019
This was removed in openshift-metal3#758 but it turns out the default origin builds still contain old ironic images, ref discussion on openshift/ironic-inspector-image#17 It also seems sane to ensure the release image set in dev-scripts is the same as the installer, which currently is not the case, we're defaulting to ocp builds and the installer to origin. Closes: openshift-metal3#775
hardys
pushed a commit
to hardys/dev-scripts
that referenced
this pull request
Aug 28, 2019
This was removed in openshift-metal3#758 but it turns out the default origin builds still contain old ironic images, ref discussion on openshift/ironic-inspector-image#17 This means we need to set the installer release image override in the case where export KNI_INSTALL_FROM_GIT=true, or we'll get the default from the openshift/installer source, and that currently won't work. Closes: openshift-metal3#775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes dev-scripts to use oc adm release extract, which produces
an openshift-baremetal-install binary with the release payload set from
which it was extracted. This means we no longer need to set
OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE.