Make it easier to drop the release override. #36
Conversation
This is based on feedback from openshift-kni#35. The release override can be dropped once the oc changes merge that allow us to extract the installer with the release image set appropriately. Move the release override var to one spot where it'll easily be removed when the time comes. Also drop "create manifests", as we don't use it yet, and it's unclear if we'll keep it at all.
|
Do we want to change it in dev-scripts as well to keep the usage as close as possible? |
Yeah, that makes sense |
|
openshift/oc#57 is approved so if you want to wait a little bit we can probably do it all in one PR |
Sure, let's do that. There's no rush on this. |
|
openshift-metal3/dev-scripts#758 was merged, if you wanted to do something similar here. Note, you'll have to extract oc from the release image (using an older oc) to get one with baremetal-installer image support. It's not available on https://mirror.openshift.com/pub/openshift-v4/clients/oc/. |
|
@russellb See that in dev_scripts the setting of override was re-instated, but since we will not compile in this repo, should we remove? Also can you add the oc extract? |
|
I'll drop this PR in favor of one that adjusts this script to use |
3 participants
This is based on feedback from #35.
The release override can be dropped once the oc changes merge that
allow us to extract the installer with the release image set
appropriately. Move the release override var to one spot where it'll
easily be removed when the time comes.
Also drop "create manifests", as we don't use it yet, and it's unclear
if we'll keep it at all.