AGENT-616: Create unconfigured ignition and config-image and mount to VM #1533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfournie
force-pushed
the
agent-appliance
branch
from
c25e5c4 to
980c03b
Compare
Contributor
|
/cc @rwsu |
danielerez
reviewed
Jun 27, 2023
danielerez
reviewed
Jun 28, 2023
danielerez
reviewed
Jun 28, 2023
openshift-merge-robot
added
the
needs-rebase
bfournie
force-pushed
the
agent-appliance
branch
from
980c03b to
a6fe782
Compare
openshift-merge-robot
removed
the
needs-rebase
bfournie
force-pushed
the
agent-appliance
branch
from
a6fe782 to
1b80a87
Compare
rwsu
reviewed
Jun 30, 2023
bfournie
force-pushed
the
agent-appliance
branch
from
1b80a87 to
762fb32
Compare
danielerez
added a commit
to danielerez/dev-scripts
that referenced
this pull request
Jul 6, 2023
Added support for running the agent flow using the openshift-appliance[1] disk image. To invoke the flow, use the following env var in config: export AGENT_E2E_TEST_BOOT_MODE=DISKIMAGE The appliance flow is as follows: * Generate appliance-config.yaml[2] * Includes config required for building the appliance * Build the appliance disk image using the container image defined in APPLIANCE_IMAGE env var * Create the config-image ISO * Clone the appliance disk image for every node * As each node needs a seperate disk for exclusive i/o * Attach a cloned disk image to each node * Attach the config-image ISO to all nodes * Boot all machines from the disk image Note: based on config-image support PR[3] [1] https://github.com/openshift/appliance [2] https://github.com/openshift/appliance/blob/master/docs/user-guide.md#set-appliance-config [3] openshift-metal3#1533
danielerez
added a commit
to danielerez/dev-scripts
that referenced
this pull request
Jul 6, 2023
Added support for running the agent flow using the openshift-appliance[1] disk image. To invoke the flow, use the following env var in config: export AGENT_E2E_TEST_BOOT_MODE=DISKIMAGE The appliance flow is as follows: * Generate appliance-config.yaml[2] * Includes config required for building the appliance * Build the appliance disk image using the container image defined in APPLIANCE_IMAGE env var * Create the config-image ISO * Clone the appliance disk image for every node * As each node needs a seperate disk for exclusive i/o * Attach a cloned disk image to each node * Attach the config-image ISO to all nodes * Boot all machines from the disk image Note: based on config-image support PR[3] [1] https://github.com/openshift/appliance [2] https://github.com/openshift/appliance/blob/master/docs/user-guide.md#set-appliance-config [3] openshift-metal3#1533
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
rwsu
reviewed
Jul 10, 2023
bfournie
force-pushed
the
agent-appliance
branch
from
f2cf6e9 to
c2185ed
Compare
andfasano
reviewed
Jul 11, 2023
agent/06_agent_create_cluster.sh
Outdated
|
|
||
| "${openshift_install}" --dir="${asset_dir}" --log-level=debug agent create unconfigured-ignition | ||
| base_iso_url=$(oc adm release info --registry-config "$PULL_SECRET_FILE" --image-for=machine-os-images --insecure=true $OPENSHIFT_RELEASE_IMAGE) | ||
| oc image extract --path /coreos/coreos-x86_64.iso:$HOME/.cache/agent/image_cache --registry-config "$PULL_SECRET_FILE" --confirm $base_iso_url |
Member
There was a problem hiding this comment.
This could break for ARM deployments (arch hard-coded to x86_64)?
Contributor
Author
There was a problem hiding this comment.
Good catch. Changed to use uname
This provides a test for both https://issues.redhat.com/browse/AGENT-558 and https://issues.redhat.com/browse/AGENT-559. It runs the installer commands to create an unconfigured ignition and to create a config-image. It creates an ISO from the unconfigured ignition suitable for booting the VM. It also attaches the config-image to the VM which will be loaded when detected during system boot.
bfournie
force-pushed
the
agent-appliance
branch
from
c2185ed to
b19d500
Compare
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
danielerez
added a commit
to danielerez/dev-scripts
that referenced
this pull request
Jul 12, 2023
Added support for running the agent flow using the openshift-appliance[1] disk image. To invoke the flow, use the following env var in config: export AGENT_E2E_TEST_BOOT_MODE=DISKIMAGE The appliance flow is as follows: * Generate appliance-config.yaml[2] * Includes config required for building the appliance * Build the appliance disk image using the container image defined in APPLIANCE_IMAGE env var * Create the config-image ISO * Clone the appliance disk image for every node * As each node needs a seperate disk for exclusive i/o * Attach a cloned disk image to each node * Attach the config-image ISO to all nodes * Boot all machines from the disk image Note: based on config-image support PR[3] [1] https://github.com/openshift/appliance [2] https://github.com/openshift/appliance/blob/master/docs/user-guide.md#set-appliance-config [3] openshift-metal3#1533
danielerez
added a commit
to danielerez/dev-scripts
that referenced
this pull request
Jul 14, 2023
Added support for running the agent flow using the openshift-appliance[1] disk image. To invoke the flow, use the following env var in config: export AGENT_E2E_TEST_BOOT_MODE=DISKIMAGE The appliance flow is as follows: * Generate appliance-config.yaml[2] * Includes config required for building the appliance * Build the appliance disk image using the container image defined in APPLIANCE_IMAGE env var * Create the config-image ISO * Clone the appliance disk image for every node * As each node needs a seperate disk for exclusive i/o * Attach a cloned disk image to each node * Attach the config-image ISO to all nodes * Boot all machines from the disk image Note: based on config-image support PR[3] [1] https://github.com/openshift/appliance [2] https://github.com/openshift/appliance/blob/master/docs/user-guide.md#set-appliance-config [3] openshift-metal3#1533
danielerez
added a commit
to danielerez/dev-scripts
that referenced
this pull request
Jul 18, 2023
Added support for running the agent flow using the openshift-appliance[1] disk image. To invoke the flow, use the following env var in config: export AGENT_E2E_TEST_BOOT_MODE=DISKIMAGE The appliance flow is as follows: * Generate appliance-config.yaml[2] * Includes config required for building the appliance * Build the appliance disk image using the container image defined in APPLIANCE_IMAGE env var * Create the config-image ISO * Clone the appliance disk image for every node * As each node needs a seperate disk for exclusive i/o * Attach a cloned disk image to each node * Attach the config-image ISO to all nodes * Boot all machines from the disk image Note: based on config-image support PR[3] [1] https://github.com/openshift/appliance [2] https://github.com/openshift/appliance/blob/master/docs/user-guide.md#set-appliance-config [3] openshift-metal3#1533
danielerez
added a commit
to danielerez/dev-scripts
that referenced
this pull request
Jul 18, 2023
Added support for running the agent flow using the openshift-appliance[1] disk image. To invoke the flow, use the following env var in config: export AGENT_E2E_TEST_BOOT_MODE=DISKIMAGE The appliance flow is as follows: * Generate appliance-config.yaml[2] * Includes config required for building the appliance * Build the appliance disk image using the container image defined in APPLIANCE_IMAGE env var * Create the config-image ISO * Clone the appliance disk image for every node * As each node needs a seperate disk for exclusive i/o * Attach a cloned disk image to each node * Attach the config-image ISO to all nodes * Boot all machines from the disk image Note: based on config-image support PR[3] [1] https://github.com/openshift/appliance [2] https://github.com/openshift/appliance/blob/master/docs/user-guide.md#set-appliance-config [3] openshift-metal3#1533
danielerez
added a commit
to danielerez/dev-scripts
that referenced
this pull request
Jul 18, 2023
Added support for running the agent flow using the openshift-appliance[1] disk image. To invoke the flow, use the following env var in config: export AGENT_E2E_TEST_BOOT_MODE=DISKIMAGE The appliance flow is as follows: * Generate appliance-config.yaml[2] * Includes config required for building the appliance * Build the appliance disk image using the container image defined in APPLIANCE_IMAGE env var * Create the config-image ISO * Clone the appliance disk image for every node * As each node needs a seperate disk for exclusive i/o * Attach a cloned disk image to each node * Attach the config-image ISO to all nodes * Boot all machines from the disk image Note: based on config-image support PR[3] [1] https://github.com/openshift/appliance [2] https://github.com/openshift/appliance/blob/master/docs/user-guide.md#set-appliance-config [3] openshift-metal3#1533
danielerez
added a commit
to danielerez/dev-scripts
that referenced
this pull request
Jul 19, 2023
Added support for running the agent flow using the openshift-appliance[1] disk image. To invoke the flow, use the following env var in config: export AGENT_E2E_TEST_BOOT_MODE=DISKIMAGE The appliance flow is as follows: * Generate appliance-config.yaml[2] * Includes config required for building the appliance * Build the appliance disk image using the container image defined in APPLIANCE_IMAGE env var * Create the config-image ISO * Clone the appliance disk image for every node * As each node needs a seperate disk for exclusive i/o * Attach a cloned disk image to each node * Attach the config-image ISO to all nodes * Boot all machines from the disk image Note: based on config-image support PR[3] [1] https://github.com/openshift/appliance [2] https://github.com/openshift/appliance/blob/master/docs/user-guide.md#set-appliance-config [3] openshift-metal3#1533
danielerez
added a commit
to danielerez/dev-scripts
that referenced
this pull request
Jul 27, 2023
Added support for running the agent flow using the openshift-appliance[1] disk image. To invoke the flow, use the following env var in config: export AGENT_E2E_TEST_BOOT_MODE=DISKIMAGE The appliance flow is as follows: * Generate appliance-config.yaml[2] * Includes config required for building the appliance * Build the appliance disk image using the container image defined in APPLIANCE_IMAGE env var * Create the config-image ISO * Clone the appliance disk image for every node * As each node needs a seperate disk for exclusive i/o * Attach a cloned disk image to each node * Attach the config-image ISO to all nodes * Boot all machines from the disk image Note: based on config-image support PR[3] [1] https://github.com/openshift/appliance [2] https://github.com/openshift/appliance/blob/master/docs/user-guide.md#set-appliance-config [3] openshift-metal3#1533
danielerez
added a commit
to danielerez/dev-scripts
that referenced
this pull request
Jul 27, 2023
Added support for running the agent flow using the openshift-appliance[1] disk image. To invoke the flow, use the following env var in config: export AGENT_E2E_TEST_BOOT_MODE=DISKIMAGE The appliance flow is as follows: * Generate appliance-config.yaml[2] * Includes config required for building the appliance * Build the appliance disk image using the container image defined in APPLIANCE_IMAGE env var * Create the config-image ISO * Clone the appliance disk image for every node * As each node needs a seperate disk for exclusive i/o * Attach a cloned disk image to each node * Attach the config-image ISO to all nodes * Boot all machines from the disk image Note: based on config-image support PR[3] [1] https://github.com/openshift/appliance [2] https://github.com/openshift/appliance/blob/master/docs/user-guide.md#set-appliance-config [3] openshift-metal3#1533
openshift-merge-robot
pushed a commit
that referenced
this pull request
Aug 3, 2023
Added support for running the agent flow using the openshift-appliance[1] disk image. To invoke the flow, use the following env var in config: export AGENT_E2E_TEST_BOOT_MODE=DISKIMAGE The appliance flow is as follows: * Generate appliance-config.yaml[2] * Includes config required for building the appliance * Build the appliance disk image using the container image defined in APPLIANCE_IMAGE env var * Create the config-image ISO * Clone the appliance disk image for every node * As each node needs a seperate disk for exclusive i/o * Attach a cloned disk image to each node * Attach the config-image ISO to all nodes * Boot all machines from the disk image Note: based on config-image support PR[3] [1] https://github.com/openshift/appliance [2] https://github.com/openshift/appliance/blob/master/docs/user-guide.md#set-appliance-config [3] #1533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a test for both https://issues.redhat.com/browse/AGENT-558 and https://issues.redhat.com/browse/AGENT-559. It runs the installer commands to create an unconfigured ignition and to create a config-image. It creates an ISO from the unconfigured ignition suitable for booting the VM. It also attaches the config-image to the VM which will be loaded when detected during system boot.
Also adds a new config setting
AGENT_APPLIANCE_HOTPLUGthat when set will configure the hosts using the unconfigured ignition and then pend for user input before creating the config-image and mounting it to the host. This emulates a situation where a user boots the host first before adding the config-image and continuing the installation.