Skip to content

AGENT-563: Create configuration image #7157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 16, 2023
Merged

AGENT-563: Create configuration image #7157

openshift-merge-robot merged 1 commit into from
Jun 16, 2023

Conversation

@bfournie
Copy link
Contributor

@bfournie bfournie commented May 3, 2023 •
edited
Loading

Adds a new installer command - openshift-install agent create config-image that will:

  • generate an ignition from the provided manifests
  • retrieve the files necessary for configuration from ignition
  • create a cpio archive containing the config files
  • generate an ISO (agentconfig.noarch.iso) with only the cpio archive (configiso.gz)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 3, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 3, 2023 •
edited by openshift-ci bot
Loading

@bfournie: This pull request references AGENT-563 which is a valid jira issue.

Details

In response to this:

Adds a new installer command - openshift-install agent create config-image that will:

  • generate an ignition from the provided manifests
  • retrieve the files necessary for configuration from ignition
  • create a cpio archive containing the config files
  • generate an ISO with only the cpio archive

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from lranjbar and sadasu May 3, 2023 12:09
@bfournie bfournie force-pushed the config-iso branch 4 times, most recently from ebb4948 to 4895c70 Compare May 3, 2023 14:36
@bfournie
Copy link
Contributor Author

bfournie commented May 3, 2023

/cc @rwsu @zaneb

@openshift-ci openshift-ci bot requested review from rwsu and zaneb May 3, 2023 16:54
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 3, 2023 •
edited by openshift-ci bot
Loading

@bfournie: This pull request references AGENT-563 which is a valid jira issue.

Details

In response to this:

Adds a new installer command - openshift-install agent create config-image that will:

  • generate an ignition from the provided manifests
  • retrieve the files necessary for configuration from ignition
  • create a cpio archive containing the config files
  • generate an ISO (agentconfig.iso) with only the cpio archive (configiso.gz)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Contributor Author

bfournie commented May 3, 2023

/cc @andfasano

@openshift-ci openshift-ci bot requested a review from andfasano May 3, 2023 17:36
@bfournie
Copy link
Contributor Author

bfournie commented May 3, 2023

/retest

andfasano
andfasano reviewed May 4, 2023
View reviewed changes
pawanpinjarkar
pawanpinjarkar reviewed May 5, 2023
View reviewed changes
pawanpinjarkar
pawanpinjarkar suggested changes May 5, 2023
View reviewed changes
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you add an integration test?

@bfournie
Copy link
Contributor Author

bfournie commented May 5, 2023 •
edited
Loading

Also, can you add an integration test?

Added

@bfournie bfournie force-pushed the config-iso branch 3 times, most recently from 05ea6e7 to 17849e8 Compare May 8, 2023 01:07
@bfournie
Copy link
Contributor Author

bfournie commented May 8, 2023

/retest

rwsu
rwsu suggested changes May 8, 2023
View reviewed changes
danielerez
danielerez reviewed May 15, 2023
View reviewed changes
zaneb
zaneb reviewed May 16, 2023
View reviewed changes
@bfournie bfournie force-pushed the config-iso branch 3 times, most recently from f74388c to 05a49f7 Compare May 22, 2023 00:07
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 8, 2023 •
edited by openshift-ci bot
Loading

@bfournie: This pull request references AGENT-563 which is a valid jira issue.

Details

In response to this:

Adds a new installer command - openshift-install agent create config-image that will:

  • generate an ignition from the provided manifests
  • retrieve the files necessary for configuration from ignition
  • create a cpio archive containing the config files
  • generate an ISO (agentconfig.noarch.iso) with only the cpio archive (configiso.gz)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie
Copy link
Contributor Author

bfournie commented Jun 8, 2023

/test e2e-agent-compact-ipv4

@bfournie
Copy link
Contributor Author

bfournie commented Jun 9, 2023

Tested in dev-scripts as part of openshift-metal3/dev-scripts#1533

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
rwsu
rwsu reviewed Jun 9, 2023
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@bfournie
Copy link
Contributor Author

bfournie commented Jun 12, 2023

/cc @patrickdillon

@openshift-ci openshift-ci bot requested a review from patrickdillon June 12, 2023 12:36
@sadasu
Copy link
Contributor

sadasu commented Jun 12, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
rwsu
rwsu reviewed Jun 13, 2023
View reviewed changes
Copy link
Contributor

@rwsu rwsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@bfournie
Copy link
Contributor Author

bfournie commented Jun 13, 2023

/retest

@bfournie
Copy link
Contributor Author

bfournie commented Jun 14, 2023

/test e2e-agent-sno-ipv6

@deepsm007
Copy link
Contributor

deepsm007 commented Jun 15, 2023

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 15, 2023
@bfournie
AGENT-563: Create configuration image
386d4aa 
Adds a new installer command - `openshift-install agent create config-image`
that will:
- generate an ignition from the provided manifests
- retrieve the files necessary for configuration from ignition
- create a cpio archive containing the config files
- generate an ISO with only the cpio archive
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023
@pawanpinjarkar
Copy link
Contributor

pawanpinjarkar commented Jun 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2023

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 386d4aa link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-upgrade 386d4aa link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn 386d4aa link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 469bd3f into openshift:master Jun 16, 2023
@bfournie bfournie deleted the config-iso branch June 16, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zaneb zaneb zaneb left review comments

@lranjbar lranjbar Awaiting requested review from lranjbar

@sadasu sadasu Awaiting requested review from sadasu

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

+4 more reviewers

@rwsu rwsu rwsu requested changes

@danielerez danielerez danielerez left review comments

@andfasano andfasano andfasano left review comments

@pawanpinjarkar pawanpinjarkar pawanpinjarkar requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rwsu rwsu

@pawanpinjarkar pawanpinjarkar

@andfasano andfasano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@bfournie @openshift-ci-robot @andfasano @sadasu @deepsm007 @pawanpinjarkar @zaneb @rwsu @danielerez @openshift-merge-robot