[wip] AGENT-611 Add support for unconfigured ignition #1531
Conversation
Introduces AGENT_USE_APPLIANCE_MODEL environment variable. Setting this variable to true will generate an agent ISO containing the unconfigured ignition.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| function create_factory_image() { | ||
| "${openshift_install}" --dir="${asset_dir}" --log-level=debug agent create cluster-manifests | ||
| "${openshift_install}" --dir="${asset_dir}" --log-level=debug agent create unconfigured-ignition | ||
| oc adm release info --image-for=machine-os-images --insecure=true $OPENSHIFT_RELEASE_IMAGE |
| "${openshift_install}" --dir="${asset_dir}" --log-level=debug agent create cluster-manifests | ||
| "${openshift_install}" --dir="${asset_dir}" --log-level=debug agent create unconfigured-ignition | ||
| oc adm release info --image-for=machine-os-images --insecure=true $OPENSHIFT_RELEASE_IMAGE | ||
| base_iso_url=$(oc adm release info --image-for=machine-os-images --insecure=true $OPENSHIFT_RELEASE_IMAGE) |
There was a problem hiding this comment.
nit: more than a base_iso_url it's a pullspec
| oc image extract --path /coreos/coreos-x86_64.iso:$HOME/.cache/agent/image_cache --confirm $base_iso_url | ||
| local agent_iso_abs_path="$(realpath "${OCP_DIR}")" | ||
| podman run --privileged --rm -v /run/udev:/run/udev -v "${agent_iso_abs_path}:${agent_iso_abs_path}" -v "$HOME/.cache/agent/image_cache/:$HOME/.cache/agent/image_cache/" quay.io/coreos/coreos-installer:release iso ignition embed -f -i "${agent_iso_abs_path}/unconfigured-agent.ign" -o "${agent_iso_abs_path}/agent.iso" $HOME/.cache/agent/image_cache/coreos-x86_64.iso | ||
| } |
There was a problem hiding this comment.
Not sure I'm missing something, but how are we going to test/exercise this new mode? I suppose that maybe another set of changes/PR will follow up, to implement the full workflow?
There was a problem hiding this comment.
I should have marked this wip. Bob has taken this PR and added the entire workflow here #1533. Will close this one.
rwsu
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Closing this PR. It has been incorporated into #1533 |
2 participants
Introduces AGENT_USE_APPLIANCE_MODEL environment variable. Setting this variable to true will generate an agent ISO containing the unconfigured ignition.
Depends on: openshift/installer#7186