Skip to content

Add ARM support #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 9, 2022
Merged

Add ARM support #1350

openshift-merge-robot merged 1 commit into from
May 9, 2022

Conversation

@bn222
Copy link
Contributor

@bn222 bn222 commented Feb 8, 2022

No description provided.

@openshift-ci openshift-ci bot requested review from andfasano and celebdor February 8, 2022 12:16
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2022

Hi @bn222. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hardys
Copy link

hardys commented Feb 8, 2022

/ok-to-test

Thanks for starting this! :)

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2022
hardys
hardys reviewed Feb 9, 2022
View reviewed changes
hardys
hardys reviewed Feb 9, 2022
View reviewed changes
hardys
hardys reviewed Feb 9, 2022
View reviewed changes
hardys
hardys reviewed Feb 9, 2022
View reviewed changes
elfosardo
elfosardo suggested changes Feb 10, 2022
View reviewed changes
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2022
@bn222
Copy link
Contributor Author

bn222 commented Mar 15, 2022

openshift/installer#5698 would be needed as well.

Are there any other remarks for this PR?

@elfosardo
Copy link
Member

elfosardo commented Mar 16, 2022

/retest

1 similar comment
@elfosardo
Copy link
Member

elfosardo commented Mar 22, 2022

/retest

@elfosardo
Copy link
Member

elfosardo commented Mar 22, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2022
elfosardo
elfosardo suggested changes Mar 22, 2022
View reviewed changes
Copy link
Member

@elfosardo elfosardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, just spot a thing

@bn222 bn222 force-pushed the master branch 2 times, most recently from 82a3ae4 to ee7a950 Compare March 22, 2022 16:27
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2022
elfosardo
elfosardo suggested changes Mar 22, 2022
View reviewed changes
@elfosardo
Copy link
Member

elfosardo commented Mar 23, 2022

/retest

@elfosardo
Copy link
Member

elfosardo commented Mar 23, 2022

/retest packet issues

@elfosardo
Copy link
Member

elfosardo commented Mar 24, 2022

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2022
@elfosardo
Copy link
Member

elfosardo commented Mar 25, 2022

/lgtm

@elfosardo
Copy link
Member

elfosardo commented Mar 25, 2022

/cc @derekhiggins

@openshift-ci openshift-ci bot requested a review from derekhiggins March 25, 2022 09:35
@elfosardo
Copy link
Member

elfosardo commented Mar 29, 2022

/retest

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022
@bn222
Copy link
Contributor Author

bn222 commented Apr 5, 2022

/retest

1 similar comment
@elfosardo
Copy link
Member

elfosardo commented Apr 8, 2022

/retest

jeffdyoung
jeffdyoung reviewed Apr 28, 2022
View reviewed changes
@bn222
Copy link
Contributor Author

bn222 commented May 6, 2022

/retest

@deepsm007
Copy link

deepsm007 commented May 6, 2022

/retest-required

@hardys
Copy link

hardys commented May 6, 2022

/override ci/prow/e2e-metal-ipi-proxy-ipv6
/override ci/prow/e2e-metal-ipi-proxy-ipv4

These jobs are failing, investigation/fixes ongoing but unrelated to this PR openshift/origin#27093 is one fix but I'm not yet sure what the root-cause is on the ipv6 job cc @elfosardo @andfasano

@openshift-ci
Copy link

openshift-ci bot commented May 6, 2022

@hardys: Overrode contexts on behalf of hardys: ci/prow/e2e-metal-ipi-proxy-ipv4, ci/prow/e2e-metal-ipi-proxy-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-proxy-ipv6
/override ci/prow/e2e-metal-ipi-proxy-ipv4

These jobs are failing, investigation/fixes ongoing but unrelated to this PR openshift/origin#27093 is one fix but I'm not yet sure what the root-cause is on the ipv6 job cc @elfosardo @andfasano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hardys
Copy link

hardys commented May 6, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented May 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2022
@hardys
Copy link

hardys commented May 9, 2022

/override ci/prow/e2e-metal-ipi-proxy-ipv6
/override ci/prow/e2e-metal-ipi-proxy-ipv4

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2022

@hardys: Overrode contexts on behalf of hardys: ci/prow/e2e-metal-ipi-proxy-ipv4, ci/prow/e2e-metal-ipi-proxy-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-proxy-ipv6
/override ci/prow/e2e-metal-ipi-proxy-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhjanders
Copy link

rhjanders commented May 9, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 70d5b49 into openshift-metal3:master May 9, 2022
@carbonin carbonin mentioned this pull request May 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@celebdor celebdor Awaiting requested review from celebdor

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

3 more reviewers

@hardys hardys hardys left review comments

@jeffdyoung jeffdyoung jeffdyoung left review comments

@elfosardo elfosardo elfosardo requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@elfosardo elfosardo

@rhjanders rhjanders

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bn222 @hardys @elfosardo @deepsm007 @rhjanders @jeffdyoung @openshift-merge-robot