Skip to content

Conversation

@carbonin
Copy link
Contributor

@carbonin carbonin commented Mar 11, 2022

The ocpmetal image is no longer being maintained or updated.
All assisted images should now be pulled from edge-infrastructure.

cc @dtantsur

@openshift-ci openshift-ci bot requested review from andfasano and russellb March 11, 2022 16:04
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2022

Hi @carbonin. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@carbonin carbonin force-pushed the update_assisted_index_image branch from be66c83 to 6709f3b Compare March 11, 2022 16:04
@dtantsur
Copy link
Member

/ok-to-test
/approve

Thanks!

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2022
Copy link
Contributor

@flaper87 flaper87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022
@carbonin
Copy link
Contributor Author

/retest

@mkowalski
Copy link
Member

I tested manually and works. Without this PR make assisted does not deploy correctly, with this PR it works 💪🏻

@mkowalski
Copy link
Member

/retest-required

1 similar comment
@mkowalski
Copy link
Member

/retest-required

@flaper87
Copy link
Contributor

/retest
/lgtm

@carbonin
Copy link
Contributor Author

/retest

@eranco74
Copy link

eranco74 commented Apr 6, 2022

/retest-required

@mkowalski
Copy link
Member

/test e2e-metal-ipi-ovn-ipv6

@carbonin
Copy link
Contributor Author

/retest-required

The ocpmetal image is no longer being maintained or updated.
All assisted images should now be pulled from edge-infrastructure.
@carbonin carbonin force-pushed the update_assisted_index_image branch from 6709f3b to 8037f78 Compare April 22, 2022 15:12
@carbonin
Copy link
Contributor Author

I don't understand why tests keep failing here so I rebased. Maybe that will help?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022
@mkowalski
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022
@elfosardo
Copy link
Member

/retest

@mkowalski
Copy link
Member

/retest-required

1 similar comment
@carbonin
Copy link
Contributor Author

/retest-required

@carbonin
Copy link
Contributor Author

These tests haven't passed on any PR as far as I can see. Can someone override them please?

@carbonin
Copy link
Contributor Author

@hardys I noticed you overrode these jobs on #1350 (comment)

Any chance we can not run these on PRs until they're fixed? They seem to be blocking quite a few patches in this repo.

@hardys
Copy link

hardys commented Jun 15, 2022

/override ci/prow/e2e-metal-ipi-proxy-ipv6
/override ci/prow/e2e-metal-ipi-proxy-ipv4

These are still failing, we need to either fix them or remove the blocking status - sorry @carbonin I missed your earlier comment!

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2022

@hardys: Overrode contexts on behalf of hardys: ci/prow/e2e-metal-ipi-proxy-ipv4, ci/prow/e2e-metal-ipi-proxy-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-proxy-ipv6
/override ci/prow/e2e-metal-ipi-proxy-ipv4

These are still failing, we need to either fix them or remove the blocking status - sorry @carbonin I missed your earlier comment!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hardys
Copy link

hardys commented Jun 15, 2022

/retest-required

1 similar comment
@javipolo
Copy link

/retest-required

@elfosardo
Copy link
Member

/retest

@elfosardo
Copy link
Member

I proposed openshift/origin#27263 that should fix the issue we're seeing in the ipv6 jobs with the watch channels for the etcd-operator

@mkowalski
Copy link
Member

Can we override to unblock and remove the need for manual cherry-picks in all dev environments? The ipi-ovn-ipv6 job does not use at all the assisted_deployment.sh file that we have modified here, so looks like we are solving an issue that belongs somewhere else

@dtantsur
Copy link
Member

/override e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2022

@dtantsur: /override requires a failed status context or a job name to operate on.
The following unknown contexts were given:

  • e2e-metal-ipi-ovn-ipv6

Only the following contexts were expected:

  • ci/prow/e2e-metal-ipi
  • ci/prow/e2e-metal-ipi-ovn-dualstack
  • ci/prow/e2e-metal-ipi-ovn-ipv6
  • ci/prow/e2e-metal-ipi-proxy-ipv4
  • ci/prow/e2e-metal-ipi-proxy-ipv6
  • ci/prow/e2e-metal-ipi-serial-ipv4
  • ci/prow/e2e-metal-ipi-serial-ovn-ipv6
  • ci/prow/e2e-metal-ipi-virtualmedia
  • ci/prow/images
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-proxy-ipv4
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-proxy-ipv6
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-serial-ipv4
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-serial-ovn-ipv6
  • pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-virtualmedia
  • pull-ci-openshift-metal3-dev-scripts-master-images
  • tide
Details

In response to this:

/override e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member

/override ci/prow/e2e-metal-ipi-ovn-ipv6

@openshift-ci
Copy link

openshift-ci bot commented Jun 21, 2022

@dtantsur: Overrode contexts on behalf of dtantsur: ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 05bed3d into openshift-metal3:master Jun 21, 2022
@carbonin
Copy link
Contributor Author

Thank you @hardys @dtantsur @elfosardo

@carbonin carbonin deleted the update_assisted_index_image branch June 21, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants