Skip to content

Bug 2091547: Skip internet connection test if we use a proxy #27093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 3, 2022
Merged

Bug 2091547: Skip internet connection test if we use a proxy #27093

openshift-merge-robot merged 1 commit into from
Jun 3, 2022

Conversation

@elfosardo
Copy link
Contributor

@elfosardo elfosardo commented May 3, 2022

Proxy jobs run in an isolated network, the nc command does not correctly
use the proxy configuration defined in the system and the test
constantly fails.

@elfosardo elfosardo force-pushed the skip-internet-proxy branch from 81c68f7 to acec9f9 Compare May 3, 2022 16:31
@elfosardo
Copy link
Contributor Author

elfosardo commented May 4, 2022

/cc @hardys @andfasano

@openshift-ci openshift-ci bot requested review from andfasano and hardys May 4, 2022 06:57
@elfosardo
Copy link
Contributor Author

elfosardo commented May 4, 2022

/retest

@andfasano
Copy link
Contributor

andfasano commented May 4, 2022

Since it's impacting the baremetal jobs, I'd suggest to run (some of) the optional baremetal jobs:

/test 2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6

@elfosardo
Copy link
Contributor Author

elfosardo commented May 4, 2022

/test e2e-metal-ipi-proxy-ipv4

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

@elfosardo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-serial
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking
  • /test images
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-cgroupsv2
  • /test e2e-aws-csi
  • /test e2e-aws-csi-migration
  • /test e2e-aws-disruptive
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-proxy
  • /test e2e-aws-single-node
  • /test e2e-aws-single-node-serial
  • /test e2e-aws-single-node-upgrade
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-cmd
  • pull-ci-openshift-origin-master-e2e-aws-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-fips
  • pull-ci-openshift-origin-master-e2e-aws-serial
  • pull-ci-openshift-origin-master-e2e-aws-single-node
  • pull-ci-openshift-origin-master-e2e-aws-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp
  • pull-ci-openshift-origin-master-e2e-gcp-builds
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-upgrade
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps
Details

In response to this:

/test e2e-metal-ipi-proxy-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link
Contributor Author

elfosardo commented May 4, 2022

/test 2e-metal-ipi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

@elfosardo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-serial
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-metal-ipi-serial-ovn-ipv6
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking
  • /test images
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-agnostic-cmd
  • /test e2e-aws
  • /test e2e-aws-cgroupsv2
  • /test e2e-aws-csi
  • /test e2e-aws-csi-migration
  • /test e2e-aws-disruptive
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-proxy
  • /test e2e-aws-single-node
  • /test e2e-aws-single-node-serial
  • /test e2e-aws-single-node-upgrade
  • /test e2e-aws-upgrade
  • /test e2e-azure
  • /test e2e-gcp-csi
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-fips-serial
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-serial
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack
  • /test e2e-openstack-serial
  • /test e2e-vsphere
  • /test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-origin-master-e2e-agnostic-cmd
  • pull-ci-openshift-origin-master-e2e-aws-cgroupsv2
  • pull-ci-openshift-origin-master-e2e-aws-csi
  • pull-ci-openshift-origin-master-e2e-aws-fips
  • pull-ci-openshift-origin-master-e2e-aws-serial
  • pull-ci-openshift-origin-master-e2e-aws-single-node
  • pull-ci-openshift-origin-master-e2e-aws-single-node-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp
  • pull-ci-openshift-origin-master-e2e-gcp-builds
  • pull-ci-openshift-origin-master-e2e-gcp-csi
  • pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
  • pull-ci-openshift-origin-master-e2e-gcp-upgrade
  • pull-ci-openshift-origin-master-images
  • pull-ci-openshift-origin-master-verify
  • pull-ci-openshift-origin-master-verify-deps
Details

In response to this:

/test 2e-metal-ipi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link
Contributor Author

elfosardo commented May 4, 2022

/test e2e-metal-ipi

@elfosardo
Copy link
Contributor Author

elfosardo commented May 4, 2022

/retest-required

@elfosardo
Copy link
Contributor Author

elfosardo commented May 4, 2022

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6

@elfosardo
Copy link
Contributor Author

elfosardo commented May 5, 2022

/test e2e-aws-fips
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6

@hardys hardys mentioned this pull request May 6, 2022
Merged
@elfosardo
Copy link
Contributor Author

elfosardo commented May 9, 2022

/retest

@stbenjam
Copy link
Member

stbenjam commented May 12, 2022

Can you share a link to where this is failing? The proxy metal uses is from the CI cluster to the test cluster. It shouldn’t affect Internet egress from the test cluster. I wouldn’t expect it to work on IPv6 but that’s already excluded via the skip disconnected annotation.

@stbenjam
Copy link
Member

stbenjam commented May 12, 2022 •
edited
Loading

Can you share a link to where this is failing? The proxy metal uses is from the CI cluster to the test cluster. It shouldn’t affect Internet egress from the test cluster. I wouldn’t expect it to work on IPv6 but that’s already excluded via the skip disconnected annotation.

All metal jobs use a proxy to reach the cluster, but there's also a job variant that runs a proxy in the cluster

From Slack:
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-metal3_dev-scripts/1393/pull-ci-openshift-metal3-dev-scripts-master-e2e-metal-ipi-proxy-ipv4/1524440512965120000

@stbenjam
Copy link
Member

stbenjam commented May 12, 2022

/lgtm

@elfosardo elfosardo force-pushed the skip-internet-proxy branch from acec9f9 to 9af0a8b Compare May 12, 2022 13:06
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels May 12, 2022
@stbenjam
Copy link
Member

stbenjam commented May 12, 2022

/lgtm
https://bugzilla.redhat.com/show_bug.cgi?id=2084560 tracks fixing this, nc should be able to use a proxy with -X

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2022
stbenjam
stbenjam reviewed May 12, 2022
View reviewed changes
test/extended/util/annotate/rules.go Outdated
`\[sig-network\] DNS should resolve DNS of partial qualified names for services`,
`\[sig-arch\] Only known images used by tests`,
`\[sig-network\] DNS should provide DNS for the cluster`,
// This test does not work when using in-proxy cluster, see https://bugzilla.redhat.com/show_bug.cgi?id=2084560
Copy link
Member

@stbenjam stbenjam May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this indentation is making go fmt unhappy

@openshift-bot
Copy link
Contributor

openshift-bot commented May 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2022

@elfosardo: This pull request references Bugzilla bug 2091547, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link
Contributor Author

elfosardo commented May 30, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 30, 2022

/retest-required

Remaining retests: 2 against base HEAD f0eef9f and 8 for PR HEAD ff1c18a in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 30, 2022

/retest-required

Remaining retests: 1 against base HEAD f0eef9f and 7 for PR HEAD ff1c18a in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 30, 2022

/retest-required

Remaining retests: 0 against base HEAD f0eef9f and 6 for PR HEAD ff1c18a in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2022

/retest-required

Remaining retests: 2 against base HEAD d7877e3 and 5 for PR HEAD ff1c18a in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2022

/retest-required

Remaining retests: 1 against base HEAD d7877e3 and 4 for PR HEAD ff1c18a in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 31, 2022

/retest-required

Remaining retests: 0 against base HEAD d7877e3 and 3 for PR HEAD ff1c18a in total

@elfosardo
Copy link
Contributor Author

elfosardo commented May 31, 2022

/retest

1 similar comment
@elfosardo
Copy link
Contributor Author

elfosardo commented Jun 1, 2022

/retest

@elfosardo
Copy link
Contributor Author

elfosardo commented Jun 1, 2022

/test e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2022

/retest-required

Remaining retests: 2 against base HEAD f88be40 and 2 for PR HEAD ff1c18a in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2022

/retest-required

Remaining retests: 1 against base HEAD f88be40 and 1 for PR HEAD ff1c18a in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 1, 2022

/retest-required

Remaining retests: 2 against base HEAD 56121c4 and 0 for PR HEAD ff1c18a in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 2, 2022

/hold

Revision ff1c18a was retested 9 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2022
@elfosardo
Copy link
Contributor Author

elfosardo commented Jun 2, 2022

/test e2e-metal-ipi-ovn-ipv6

@elfosardo
Copy link
Contributor Author

elfosardo commented Jun 2, 2022

/retest

@stbenjam
Copy link
Member

stbenjam commented Jun 2, 2022

/hold cancel
/refresh

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2022
@stbenjam
Copy link
Member

stbenjam commented Jun 2, 2022

/skip

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 3, 2022

/retest-required

Remaining retests: 2 against base HEAD b2943a0 and 8 for PR HEAD ff1c18a in total

@openshift-merge-robot openshift-merge-robot merged commit 63288a5 into openshift:master Jun 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

@elfosardo: All pull requests linked via external trackers have merged:

Bugzilla bug 2091547 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2091547: Skip internet connection test if we use a proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2022

@elfosardo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node-upgrade ff1c18a link false /test e2e-aws-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6 ff1c18a link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tdomnesc
Copy link

tdomnesc commented Aug 5, 2022

/cherry-pick release-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 5, 2022
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Aug 5, 2022

@tdomnesc: new pull request created: #27344

Details

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@andfasano andfasano Awaiting requested review from andfasano

@hardys hardys Awaiting requested review from hardys

@stbenjam stbenjam Awaiting requested review from stbenjam

Assignees

@stbenjam stbenjam

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@elfosardo @andfasano @stbenjam @openshift-bot @openshift-ci-robot @tdomnesc @openshift-cherrypick-robot @openshift-merge-robot