[TEST-ONLY] Remove conversion patch#2148
Closed
skonto wants to merge 1 commit intoopenshift-knative:mainfrom
skonto:test-webhook-secs
Closed
[TEST-ONLY] Remove conversion patch#2148skonto wants to merge 1 commit intoopenshift-knative:mainfrom skonto:test-webhook-secs
skonto wants to merge 1 commit intoopenshift-knative:mainfrom
skonto:test-webhook-secs
Conversation
Collaborator
skonto
commented
Jul 11, 2023
skonto
commented
- try remove this based on Allow overriding webhook secret data keys knative/pkg#2662
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: skonto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Collaborator
Author
|
Upstream PR merged knative/pkg#2662. I will create a PR to get this when 1.12 is around, 1.11 was missed for some reason. |
Collaborator
Author
|
Closing see SRVKS-1120 for future updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.