Skip to content

[SRVKS-1120] Use webhook context for secret data keys#2596

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-knative:mainfrom
skonto:webhook_secs
Apr 5, 2024
Merged

[SRVKS-1120] Use webhook context for secret data keys#2596
openshift-merge-bot[bot] merged 1 commit intoopenshift-knative:mainfrom
skonto:webhook_secs

Conversation

@skonto
Copy link
Copy Markdown
Collaborator

@skonto skonto commented Apr 3, 2024

Fixes JIRA #SRVKS-1120

Proposed Changes

@skonto skonto requested a review from ReToCode April 3, 2024 10:57
@openshift-ci openshift-ci bot requested a review from rhuss April 3, 2024 10:57
@openshift-ci openshift-ci bot added the approved label Apr 3, 2024
@skonto skonto removed the request for review from rhuss April 3, 2024 11:56
Copy link
Copy Markdown
Contributor

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold can we now also remove the USE_OLM_TLS env? Or do we use that somewhere else (I haven't checked).

@ReToCode
Copy link
Copy Markdown
Contributor

ReToCode commented Apr 4, 2024

/override "Lint"

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 4, 2024

@ReToCode: Overrode contexts on behalf of ReToCode: Lint

Details

In response to this:

/override "Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skonto
Copy link
Copy Markdown
Collaborator Author

skonto commented Apr 5, 2024

@ReToCode in order to remove that env var I have opened an upstream PR here: knative/pkg#3006.

@ReToCode
Copy link
Copy Markdown
Contributor

ReToCode commented Apr 5, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 606d4d5 into openshift-knative:main Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants