[release-v1.10] Add eventshub service port name#760
Merged
pierDipi merged 1 commit intoJul 28, 2023
Merged
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Member
Author
|
/cc @ReToCode |
pierDipi
commented
Jul 28, 2023
Member
Author
There was a problem hiding this comment.
These are generated changes (missing from previous PRs)
ReToCode
approved these changes
Jul 28, 2023
| git apply openshift/patches/disable-ko-publish-rekt.patch | ||
| git apply openshift/patches/override-min-version.patch | ||
| git apply openshift/patches/add-eventshub-port-name.patch | ||
| git apply openshift/patches/unique-secret-names.patch |
There was a problem hiding this comment.
Not sure if this should be here or not? If ok, feel free to unhold.
Member
Author
There was a problem hiding this comment.
Yes, that's missing, without this make generate-release will revert that patch
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as openshift-knative/eventing#289