Skip to content

[release-v1.9] Add eventshub service port name#289

Merged
pierDipi merged 1 commit intoopenshift-knative:release-v1.9from
pierDipi:cp-a4373f9df21a83e11755ac5172c9bf4710e6e7bf-v1.9
Jul 28, 2023
Merged

[release-v1.9] Add eventshub service port name#289
pierDipi merged 1 commit intoopenshift-knative:release-v1.9from
pierDipi:cp-a4373f9df21a83e11755ac5172c9bf4710e6e7bf-v1.9

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Jul 28, 2023

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@openshift-ci openshift-ci bot requested review from aliok and lberk July 28, 2023 09:35
@pierDipi
Copy link
Copy Markdown
Member Author

/cc @ReToCode

@openshift-ci openshift-ci bot requested a review from ReToCode July 28, 2023 09:35
@pierDipi
Copy link
Copy Markdown
Member Author

/cherry-pick release-v1.10

@openshift-cherrypick-robot
Copy link
Copy Markdown

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Copy Markdown

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi pierDipi merged commit e63b9ce into openshift-knative:release-v1.9 Jul 28, 2023
@pierDipi pierDipi deleted the cp-a4373f9df21a83e11755ac5172c9bf4710e6e7bf-v1.9 branch July 28, 2023 09:54
@openshift-cherrypick-robot
Copy link
Copy Markdown

@pierDipi: #289 failed to apply on top of branch "release-v1.10":

Applying: Add eventshub service port name
Using index info to reconstruct a base tree...
M	openshift/generate.sh
Falling back to patching base and 3-way merge...
Auto-merging openshift/generate.sh
CONFLICT (content): Merge conflict in openshift/generate.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add eventshub service port name
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-v1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants