Skip to content

Updated yq command to get the tag properly on release-v1.9#731

Closed
Cali0707 wants to merge 1 commit into
openshift-knative:release-v1.9from
Cali0707:cherry-pick-yq-fix-to-v1.9
Closed

Updated yq command to get the tag properly on release-v1.9#731
Cali0707 wants to merge 1 commit into
openshift-knative:release-v1.9from
Cali0707:cherry-pick-yq-fix-to-v1.9

Conversation

@Cali0707
Copy link
Copy Markdown
Member

@Cali0707 Cali0707 commented Jul 5, 2023

This PR cherry picks a fix to the yq command in the generate-release script onto the release-v1.9 branch

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Copy Markdown
Member Author

Cali0707 commented Jul 5, 2023

/cc @pierDipi @creydr

@openshift-ci openshift-ci Bot requested review from creydr, matzew and pierDipi July 5, 2023 13:42
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Cali0707
Once this PR has been reviewed and has the lgtm label, please assign lberk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707 Cali0707 changed the title Updated yq command to get the tag properly Updated yq command to get the tag properly on release-v1.9 Jul 5, 2023
@Cali0707
Copy link
Copy Markdown
Member Author

Cali0707 commented Jul 5, 2023

/retest-required

@creydr
Copy link
Copy Markdown

creydr commented Jul 6, 2023

@Cali0707 where did you get this error? IIRC we are (/were?!?) using yq 3 in CI (Jenkins).

@Cali0707
Copy link
Copy Markdown
Member Author

Cali0707 commented Jul 6, 2023

@Cali0707 where did you get this error? IIRC we are (/were?!?) using yq 3 in CI (Jenkins).

I got this error when I was running make generate-release locally to set up the release-v1.10 branch. I didn't know this also runs in CI, but it makes sense that it does.

@creydr if we are using yq 3 in CI, do you think that we should revert this change on the release-v1.10 branch and document somewhere that you need yq 3 locally to run this?

@creydr
Copy link
Copy Markdown

creydr commented Jul 6, 2023

@pierDipi regarding the discussions from e05f546#r120280389: I thought we are on yq 3 in Jenkins 🤔

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi regarding the discussions from e05f546#r120280389: I thought we are on yq 3 in Jenkins thinking

Yes, I thought it was an existing problem and not that Calum is on yq v4

@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Jul 19, 2023

Therefore, we need to stick with yq v3, so we need to revert/change accordingly

@pierDipi
Copy link
Copy Markdown
Member

@Cali0707 I guess the only action item left here is to revert e05f546, right?

@pierDipi
Copy link
Copy Markdown
Member

I did it in #760

@pierDipi pierDipi closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants