Skip to content

Updated yq command to get the tag properly on release-v1.8#732

Closed
Cali0707 wants to merge 1 commit into
openshift-knative:release-v1.8from
Cali0707:cherry-pick-yq-fix-to-v1.8
Closed

Updated yq command to get the tag properly on release-v1.8#732
Cali0707 wants to merge 1 commit into
openshift-knative:release-v1.8from
Cali0707:cherry-pick-yq-fix-to-v1.8

Conversation

@Cali0707
Copy link
Copy Markdown
Member

@Cali0707 Cali0707 commented Jul 5, 2023

This PR cherry picks a fix to the yq command in the generate-release script onto the release-v1.8 branch

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Copy Markdown
Member Author

Cali0707 commented Jul 5, 2023

/cc @pierDipi @creydr

@openshift-ci openshift-ci Bot requested review from aliok, creydr and pierDipi July 5, 2023 13:44
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Cali0707
Once this PR has been reviewed and has the lgtm label, please assign creydr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Copy Markdown
Member Author

Cali0707 commented Jul 5, 2023

/retest-required

@Cali0707
Copy link
Copy Markdown
Member Author

Closing based on comments on #731

@Cali0707 Cali0707 closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant