[release-4.20] OCPBUGS-77794: upgrade lodash and lodash-es to 4.17.23 to address CVE-2025-13465

[sunku5494]

Summary by CodeRabbit

Release Notes

• Chores

  • Updated base container images and dependencies to OpenShift 4.20
  • Pinned lodash dependencies to version 4.17.23 for improved security
  • Expanded CI workflow triggers to include feature/* and release-* branches

• UI/UX Improvements

  • Updated version references to OpenShift 4.20
  • Improved layout and messaging for disconnected/air-gapped environment installations
  • Changed preview designations from Developer Preview to Technology Preview
  • Refined external platform integration field visibility based on feature flags

[openshift-ci-robot]

@sunku5494: This pull request references Jira Issue OCPBUGS-77794, which is invalid:

• expected the vulnerability to target either version "4.22." or "openshift-4.22.", but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @sunku5494. Thanks for your PR.

I'm waiting for a openshift-assisted member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Caution

Review failed

Failed to post review comments

📝 Walkthrough

Walkthrough

This PR updates CI/build infrastructure to OpenShift 4.20, pins lodash dependencies to 4.17.23, implements cached Yarn bootstrap in container builds, expands GitHub Actions workflow branch triggers, replaces DeveloperPreview with TechnologyPreview components throughout the UI, adjusts feature flag logic for single-cluster installation, and updates version references from 4.19 to 4.20.

Changes

Cohort / File(s)	Summary
CI/Build Configuration .ci-operator.yaml, .github/workflows/pull-request.yaml	Added build_root_image config for golang 1.24 and OpenShift 4.20; expanded pull request workflow triggers to include feature/* and release-* branch patterns.
Container Build & Image Updates apps/assisted-disconnected-ui/Containerfile.ocp	Updated base images to OpenShift 4.20 (Node.js and Go builders); implemented artifacts-cached Yarn bootstrap with remote sources and build args; added vendored Go build flags; replaced full filesystem copy with project-local copy; updated final runtime base image.
Dependency Version Pins apps/assisted-disconnected-ui/package.json, apps/assisted-ui/package.json, libs/ui-lib/package.json, package.json	Pinned lodash to ^4.17.23 across multiple package.json files and added workspace-level resolutions for lodash/lodash-es.
UI Component Preview Badge Refactoring libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx, libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx, libs/ui-lib/lib/ocm/components/clusters/AssistedInstallerHeader.tsx	Replaced DeveloperPreview component with TechnologyPreview; updated OpenShift version references from 4.19 to 4.20.
UI Component Layout & Feature Flag Logic libs/ui-lib/lib/ocm/components/clusterWizard/ClusterDetailsForm.tsx, libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/BasicStep.tsx, libs/ui-lib/lib/ocm/components/clusterConfiguration/OcmClusterDetailsFormFields.tsx	Switched layout from PatternFly Split to Flex components; wrapped external platform integration field with isSingleClusterFeatureEnabled condition; added translated explanatory text for disconnected installations; removed Switch label.
Feature Flag Support Logic libs/ui-lib/lib/ocm/components/featureSupportLevels/ReviewClusterFeatureSupportLevels.tsx	Added isSingleClusterFeatureEnabled feature flag consumption; updated getSupportLevelInfo signature to accept and use the flag in isFullySupported and showVersionWarning calculations.
UI Component Props Updates libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/InstallDisconnectedSwitch.tsx	Removed localized label prop from Switch component.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• OCPBUGS-61953: Update dependency sourcing to remote #3155 — Directly modifies the same Containerfile.ocp with identical multi-stage build changes (base image updates to 4.20, remote-sources/CACHED_YARN bootstrap, Go vendored build).
• OCPBUGS-74470: bump lodash to ^4.17.23 to address CVE-2025-13465 #3410 — Updates the same dependency pins for lodash/lodash-es and root package.json resolutions across the workspace.
• AGENT-1388: Adding TechPreview Budge for Assisted installer and agent #3293 — Makes the same code-level UI changes across multiple files (DeveloperPreview → TechnologyPreview, Split → Flex layouts, OpenShift 4.19 → 4.20 version updates, isSingleClusterFeatureEnabled flag propagation, and getSupportLevelInfo signature changes).

Suggested labels

lgtm, approved, ok-to-test, size/M

Suggested reviewers

• batzionb
• LiorSoffer
• rawagner

Poem

🐰 ✨ From four-point-nineteen to four-point-twenty we hop,
DeveloperPreview badges swapped for TechnologyPreview on top,
Yarn caches, Go vendored, lodash pinned just right,
Flex layouts dance where Split once shined bright!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly specifies the main change: upgrading lodash and lodash-es to version 4.17.23 to address a specific CVE, which is reflected throughout the changeset (package.json updates, root resolutions, and related infrastructure updates).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

⚔️ Resolve merge conflicts

• Resolve merge conflict in branch fix-CVE-2025-13465-4.20

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@sunku5494: This pull request references Jira Issue OCPBUGS-77794, which is invalid:

• expected dependent Jira Issue OCPBUGS-81587 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jgyselov]

/ok-to-test

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgyselov, sunku5494

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jgyselov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sunku5494]

/jira refresh

[openshift-ci-robot]

@sunku5494: This pull request references Jira Issue OCPBUGS-77794, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.z) matches configured target version for branch (4.20.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-81587 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-81587 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0, 4.21.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.