OCPBUGS-76986: Above-the-sea UI QE test second phase

[ElayAharoni]

https://issues.redhat.com/browse/OCPBUGS-76986

Summary by CodeRabbit

• Bug Fixes
  • Improved MAC address validation error messaging for consistent string handling.
  • Enhanced IP address validation with clearer error messages displaying invalid input values.
  • Fixed form field indication of required IP address inputs for better user guidance.

[openshift-ci-robot]

@ElayAharoni: This pull request references Jira Issue OCPBUGS-76986, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-76986

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 34bafbf5-1e3a-4fc8-ad76-4dad16e9f0d0

📥 Commits

Reviewing files that changed from the base of the PR and between 2dd860c and 2b9c0bc.

📒 Files selected for processing (3)

• libs/ui-lib/lib/common/validationSchemas/addressValidation.tsx
• libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/commonValidationSchemas.tsx
• libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx

---

📝 Walkthrough

Walkthrough

This PR updates MAC address and IP address validation schemas to improve error messaging and input handling, and adds a required field indicator to IP address form fields in static IP configuration.

Changes

Cohort / File(s)	Summary
Validation Schema Updates libs/ui-lib/lib/common/validationSchemas/addressValidation.tsx, libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/commonValidationSchemas.tsx	MAC address validation now accepts a params object and coerces values to string with empty string fallback. IP address validation adds dynamic error messages with quoted values and explicit handling for empty and non-string inputs.
Form Field Configuration libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewHosts/FormViewHostsFields.tsx	Adds isRequired prop to FormGroup wrapping IP address fields to align with child field requirements.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• NO-ISSUE: Localise validation messages #3379: Directly related at the code level as this PR modifies the same validation schemas and form fields for MAC/IP address handling.

Suggested labels

lgtm, approved, size/M

Suggested reviewers

• rawagner
• jgyselov

Poem

🐰 A hop through schemas, refined and clear,
MAC and IP validations now appear,
With messages bright and types that care,
Forms marked required, validation fair! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references a Jira ticket (OCPBUGS-76986) but does not clearly describe the actual technical changes made in the pull request.	Update the title to describe the main technical changes: validation schema improvements for MAC addresses and IP addresses, or use a more descriptive title that captures the actual code modifications.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@ElayAharoni: This pull request references Jira Issue OCPBUGS-76986, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-76986

Summary by CodeRabbit

• Bug Fixes
• Improved MAC address validation error messaging for consistent string handling.
• Enhanced IP address validation with clearer error messages displaying invalid input values.
• Fixed form field indication of required IP address inputs for better user guidance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@ElayAharoni: Jira Issue OCPBUGS-76986: All pull requests linked via external trackers have merged:

• openshift-assisted/assisted-installer-ui#3450
• openshift-assisted/assisted-installer-ui#3453

Jira Issue OCPBUGS-76986 has been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-76986

Summary by CodeRabbit

• Bug Fixes
• Improved MAC address validation error messaging for consistent string handling.
• Enhanced IP address validation with clearer error messages displaying invalid input values.
• Fixed form field indication of required IP address inputs for better user guidance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.