OCPBUGS-76986: above sea level QE test fix

[ElayAharoni]

https://issues.redhat.com/browse/OCPBUGS-76986

Summary by CodeRabbit

• New Features

  • Validation now adapts dynamically to the provided Rendezvous IP to enforce coherence with the configured IPv4 network.

• Bug Fixes

  • Improved Rendezvous IP validation to ensure it resides within the configured IPv4 subnet, with targeted error messaging.

• Documentation

  • Updated ISO size information from approximately 43.5 GB to approximately 50 GB.

[openshift-ci-robot]

@ElayAharoni: This pull request references Jira Issue OCPBUGS-76986, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-76986

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

Refactors network validation to compute the network-wide schema at runtime via getNetworkWideValidationSchema(rendezvousIp?), adding a rendezvous-IP coherence test; updates FormViewNetworkWide to call the factory with infraEnv.rendezvousIp. Also updates ISO size text in ReviewStep.

Changes

Cohort / File(s)	Summary
Validation schema factory libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewNetworkWide/formViewNetworkWideValidationSchema.tsx	Replaced inline Yup.lazy schema with getNetworkWideValidationSchema(rendezvousIp?: string); added getRendezvousIpCoherenceTest to ensure rendezvous IP lies in the IPv4 machineNetwork subnet; exported factory and preserved networkWideValidationSchema (initialized via the factory).
Component wiring libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewNetworkWide/FormViewNetworkWide.tsx	Switched import to getNetworkWideValidationSchema and set validationSchema at runtime using getNetworkWideValidationSchema(infraEnv.rendezvousIp) instead of a static schema.
UI text update libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx	Changed displayed ISO size string from "approx. 43.5GB" to "approx. 50 GB".

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• AGENT-1406: change ABI above sea level iso size #3322 — touches the same ReviewStep.tsx ISO size string.
• MGMT-22512: Add additional new fields to the above the sea UI #3337 — introduces rendezvous IP handling and validation logic that this change relies on.

Suggested labels

lgtm, approved

Suggested reviewers

• jgyselov
• ammont82

Poem

🐰 A tiny hop, a schema born anew,
Rendezvous checked where subnets grew,
Validation wise, it learns to roam,
ISO sizes updated on its home,
Hoppity code — tests pass through! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title references bug OCPBUGS-76986 but does not clearly describe the actual changes made: Rendezvous IP validation improvements and ISO size documentation update.	Revise the title to describe the main technical changes, such as 'Improve Rendezvous IP validation within IPv4 subnet and update ISO size documentation' or similar.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@ElayAharoni: This pull request references Jira Issue OCPBUGS-76986, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-76986

Summary by CodeRabbit

• Bug Fixes

• Improved Rendezvous IP validation to ensure it resides within the configured IPv4 subnet, with localized error messaging.

• Documentation

• Updated ISO size information from approximately 43.5 GB to approximately 50 GB.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

🧹 Nitpick comments (1)

libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewNetworkWide/formViewNetworkWideValidationSchema.tsx (1)

159-160: Redundant conditional check.

getRendezvousIpCoherenceTest always returns a Yup.object(), so the ternary on line 160 is unnecessary—rendezvousTest will never be falsy.

♻️ Simplify by removing the redundant conditional

-    const rendezvousTest = getRendezvousIpCoherenceTest(rendezvousIp);
-    return rendezvousTest ? baseSchema.concat(rendezvousTest) : baseSchema;
+    return baseSchema.concat(getRendezvousIpCoherenceTest(rendezvousIp));

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewNetworkWide/formViewNetworkWideValidationSchema.tsx`
around lines 159 - 160, The ternary is redundant because
getRendezvousIpCoherenceTest(rendezvousIp) always returns a Yup.object();
replace the conditional return with a single concat call: always compute
rendezvousTest via getRendezvousIpCoherenceTest(rendezvousIp) and return
baseSchema.concat(rendezvousTest). Update the return in the function that builds
the schema (references: getRendezvousIpCoherenceTest, rendezvousTest,
baseSchema) and remove the unnecessary null/falsy branch.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewNetworkWide/formViewNetworkWideValidationSchema.tsx`:
- Around line 159-160: The ternary is redundant because
getRendezvousIpCoherenceTest(rendezvousIp) always returns a Yup.object();
replace the conditional return with a single concat call: always compute
rendezvousTest via getRendezvousIpCoherenceTest(rendezvousIp) and return
baseSchema.concat(rendezvousTest). Update the return in the function that builds
the schema (references: getRendezvousIpCoherenceTest, rendezvousTest,
baseSchema) and remove the unnecessary null/falsy branch.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ac2e6971-c291-4d11-9ffa-ca06e4c418c3

📥 Commits

Reviewing files that changed from the base of the PR and between 322b258 and 65d0ba4.

📒 Files selected for processing (3)

• libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewNetworkWide/FormViewNetworkWide.tsx
• libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewNetworkWide/formViewNetworkWideValidationSchema.tsx
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewNetworkWide/formViewNetworkWideValidationSchema.tsx`:
- Around line 143-153: The conditional Yup schema for vlanId uses object-style
when({...}) which triggers the noThenProperty lint; change it to callback-style
when by replacing Yup.mixed().when('useVlan', { is: ..., then: () => ... }) with
Yup.mixed().when('useVlan', (useVlan, schema) => useVlan ? schema.clone()... :
schema) and inside the true branch return the same number schema
(Yup.number().required(MUST_BE_A_NUMBER).min(1, ...).max(MAX_VLAN_ID,
...).test('not-number', MUST_BE_A_NUMBER, () =>
validateNumber(values.vlanId)).nullable().transform(transformNumber) ), keeping
references to vlanId, useVlan, validateNumber, transformNumber, MUST_BE_A_NUMBER
and MAX_VLAN_ID intact so lint passes.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 622f7ba6-0fd3-4223-a04a-9ea375d0dc90

📥 Commits

Reviewing files that changed from the base of the PR and between 65d0ba4 and 65c3f38.

📒 Files selected for processing (3)

• libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewNetworkWide/FormViewNetworkWide.tsx
• libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewNetworkWide/formViewNetworkWideValidationSchema.tsx
• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx

🚧 Files skipped from review as they are similar to previous changes (2)

• libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/ReviewStep.tsx
• libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/FormViewNetworkWide/FormViewNetworkWide.tsx

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@ElayAharoni: Jira Issue OCPBUGS-76986: All pull requests linked via external trackers have merged:

• openshift-assisted/assisted-installer-ui#3450

Jira Issue OCPBUGS-76986 has been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-76986

Summary by CodeRabbit

• New Features

• Validation now adapts dynamically to the provided Rendezvous IP to enforce coherence with the configured IPv4 network.

• Bug Fixes

• Improved Rendezvous IP validation to ensure it resides within the configured IPv4 subnet, with targeted error messaging.

• Documentation

• Updated ISO size information from approximately 43.5 GB to approximately 50 GB.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.