NO-ISSUE: Localise validation messages#3379
Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift-assisted:masterfrom Feb 8, 2026
Merged
NO-ISSUE: Localise validation messages#3379openshift-merge-bot[bot] merged 2 commits intoopenshift-assisted:masterfrom
openshift-merge-bot[bot] merged 2 commits intoopenshift-assisted:masterfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jgyselov: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
📝 WalkthroughWalkthroughCentralizes and modularizes form validation into new i18n-aware validators under libs/.../validationSchemas, removes the legacy monolithic formik validation bundle, threads the translation function (t) through validators and Formik usages, updates imports/exports, extends English translations, and adjusts related tests. Changes
Sequence Diagram(s)sequenceDiagram
participant User as UI Component (Formik)
participant T as i18n (t)
participant V as Validation module (validationSchemas/*)
participant Store as Form State / Submit
User->>T: useTranslation() -> t
User->>V: build validationSchema(values, t)
V-->>User: Yup schema (with localized messages)
User->>Store: submit(values)
User->>V: schema.validate(values)
V-->>User: validation result / errors (localized via t)
alt valid
User->>Store: proceed submit
else invalid
User-->>User: show localized errors
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
bot
added
the
size/XXL
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
libs/ui-lib/lib/cim/components/Agent/BMCForm.tsx (1)
159-166:⚠️ Potential issue | 🟠 MajorUse functional
wheninstead of object formBiome flags object literals with
theninwhen. Replace with a functional callback:Refactor
- macAddress: macAddressValidationSchema(t).when('name', { - is: (name: string) => !!name, - then: (schema) => schema.required(t('ai:MAC has to be specified')), - }), + macAddress: macAddressValidationSchema(t).when('name', ([name], schema) => + name ? schema.required(t('ai:MAC has to be specified')) : schema, + ), - name: Yup.string().when('macAddress', { - is: (mac: string) => !!mac, - then: (schema) => schema.required(t('ai:Name has to be specified')), - }), + name: Yup.string().when('macAddress', ([mac], schema) => + mac ? schema.required(t('ai:Name has to be specified')) : schema, + ),libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/YamlView/yamlViewValidationSchema.tsx (1)
23-75:⚠️ Potential issue | 🟡 MinorLocalize validation messages
Hardcoded strings inrequired,max, andmatchesshould be wrapped int(...)for translation.Suggested diff
- .required('Required field') + .required(t('ai:Required field')) ... - .max(15, 'Interface name must be 15 characters at most.') + .max(15, t('ai:Interface name must be 15 characters at most.')) ... - .matches(/^\S+$/, 'Interface name can not contain spaces.') + .matches(/^\S+$/, t('ai:Interface name can not contain spaces.'))libs/ui-lib/lib/common/validationSchemas/_validationSchemas.test.ts (1)
376-383:⚠️ Potential issue | 🟡 MinorAdd trailing periods to expected error strings in tests
In _validationSchemas.test.ts (lines 381, 423, 439), update expected messages to include trailing periods:Fix expected strings
- 'First network has to be IPv4 subnet' + 'First network has to be IPv4 subnet.' ... - 'ai:Maximum number of {{field}} subnets in dual stack is 2' + 'ai:Maximum number of {{field}} subnets in dual stack is 2.'
🤖 Fix all issues with AI agents
In `@libs/locales/lib/en/translation.json`:
- Line 386: Update the translation entry with key "ai:File type is not
supported. File type must be yaml, yml ,json , yaml.patch. or yml.patch." to
remove extra spaces and the stray period so both the key and value read with
consistent punctuation and spacing (e.g., "File type is not supported. File type
must be yaml, yml, json, yaml.patch or yml.patch."). Ensure you edit the exact
translation key and its value (the string in
libs/locales/lib/en/translation.json) to use the corrected spacing and
punctuation.
In `@libs/ui-lib/lib/cim/components/modals/EditSSHKeyModal.tsx`:
- Around line 24-28: The validationSchema currently passes a hardcoded string to
.required(); change it to use the translation function by replacing the literal
with t('ai:An SSH key is required to debug hosts as they register.') so the
sshPublicKey field error is localized; update the validationSchema (and any call
sites using TFunction t) to call
sshPublicKeyValidationSchema(t).required(t('ai:An SSH key is required to debug
hosts as they register.')) ensuring the message uses the ai namespace
translation key.
In `@libs/ui-lib/lib/common/validationSchemas/addressValidation.tsx`:
- Around line 110-114: Update the validation schemas to accept a translation
function and use localized messages: modify hostSubnetValidationSchema to accept
(t: TFunction) and change the notOneOf message to t('ai:Host subnet must be
selected.'), update ipBlockValidationSchema to replace .required('A value is
required.') with .required(t('ai:Required field')), and update
bmcAddressValidationSchema to change .required() to .required(t('ai:Required
field')); ensure the function signatures and callers are adjusted to pass a
TFunction (t) where these schemas are constructed or exported.
In `@libs/ui-lib/lib/common/validationSchemas/clusterDetailsValidation.tsx`:
- Around line 54-75: The Yup .when usage with an object containing
then/otherwise triggers the linter; refactor the conditional to the callback
form by replacing .when('useRedHatDnsService', { is: ..., then: ..., otherwise:
... }) with .when('useRedHatDnsService', (useRedHatDnsService, schema) => { if
(useRedHatDnsService === true) return schema.test('is-name-unique',
clusterNameValidationMessagesList.NOT_UNIQUE, (value?: string) => { const
clusterFullName = `${value || ''}.${baseDnsDomain}`; return !value ||
!usedClusterNames.includes(clusterFullName); }); return
schema.test('is-name-unique', clusterNameValidationMessagesList.NOT_UNIQUE,
(value?: string) => { return validateUniqueName ? !value ||
!usedClusterNames.includes(value) : true; }); }); so the logic around
useRedHatDnsService, clusterFullName, usedClusterNames and validateUniqueName
remains identical but uses the callback signature to satisfy the noThenProperty
rule.
In `@libs/ui-lib/lib/common/validationSchemas/constants.tsx`:
- Around line 69-70: Update the user-facing message returned by
getIncorrectFileTypeMessage to correct spacing and punctuation and list allowed
file types clearly; replace the current string in getIncorrectFileTypeMessage
(which takes t: TFunction) with a properly formatted message such as "File type
is not supported. Supported file types: yaml, yml, json, yaml.patch, yml.patch."
so the translation key receives the cleaned, human-readable text.
In `@libs/ui-lib/lib/common/validationSchemas/networkingValidation.tsx`:
- Around line 47-110: dualStackValidationSchema currently uses hardcoded test
messages—replace them with localized messages using the provided t parameter
(wrap the three test message strings: the 'dual-stack-ipv4' message, the
`Provided ${field} subnets must be unique.` message, and the `When two ${field}
are provided, one must be IPv4 and the other IPv6.` message) so they call t(...)
and include the field where needed; also change IPv4ValidationSchema from a
plain Yup.array() export into a function that accepts t: TFunction (e.g. export
const IPv4ValidationSchema = (t: TFunction) => ...) and use t('ai:All network
subnets must be IPv4.') as the test error message while still invoking
allSubnetsIPv4(values); update any call sites that import IPv4ValidationSchema
to call it with t.
In `@libs/ui-lib/lib/common/validationSchemas/proxyValidation.tsx`:
- Around line 19-37: The current Yup test registered as 'http-proxy-validation'
on the validation constant rejects https URLs for both fields; update the test
function (the arrow passed into Yup.string().test) to inspect the Yup test
context (this.path or this.parent) to distinguish the field name: when the path
ends with or equals 'httpProxy' require the value to start with 'http://' only,
and when the path is 'httpsProxy' allow values that start with either 'http://'
or 'https://'; keep the empty-value shortcut, still validate by constructing new
URL(value) inside a try/catch, and adjust the validation message text
accordingly so clients see the correct allowed schemes for each field.
In `@libs/ui-lib/lib/common/validationSchemas/utils.tsx`:
- Around line 5-12: The isIPorDN function currently calls match on a possibly
undefined value and uses match instead of test; update isIPorDN to immediately
return false if value is falsy, then use dnsRegex.test(value) to check
DNS_NAME_REGEX, and otherwise return the result of Address4.isValid(value) ||
Address6.isValid(value); reference the isIPorDN function and DNS_NAME_REGEX,
Address4.isValid, Address6.isValid when making the change.
In
`@libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx`:
- Around line 86-116: getValidationSchema uses hardcoded messages for pullSecret
and rendezvousIp (and the IP max length message); replace those literal strings
with calls to the i18n function t so validation messages are localized.
Specifically, in getValidationSchema change the pullSecret .required('Required
field') to .required(t('some.key.pullSecretRequired')) and replace the
rendezvousIp .max(45, 'IP address must be at most 45 characters') and the test
message 'Not a valid IP address' with t('some.key.ipTooLong', { count: 45 }) and
t('some.key.invalidIp') (or appropriate keys you maintain), keeping
ipValidationSchema(t) as-is; ensure the chosen translation keys exist in your
locales.
libs/ui-lib/lib/ocm/components/clusterWizard/disconnected/OptionalConfigurationsStep.tsx
Show resolved
Hide resolved
jgyselov
force-pushed
the
validation_schema_untangling
branch
from
605f770 to
f51ec5b
Compare
There was a problem hiding this comment.
Actionable comments posted: 8
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/networkConfigurationValidation.ts (1)
84-96:⚠️ Potential issue | 🟡 MinorUpdate
hostSubnetValidationSchemaandmachineNetworksValidationSchemato support i18n.
machineNetworksValidationSchemais a constant (unlikeclusterNetworksValidationSchemaandserviceNetworkValidationSchema, which are functions acceptingt). The underlying issue is thathostSubnetValidationSchemacontains a hardcoded error message'Host subnet must be selected.'that is not translated.Refactor
hostSubnetValidationSchemato accept the translation functiontand use it for the error message, then convertmachineNetworksValidationSchemato a function so it can passttohostSubnetValidationSchema, matching the pattern used by the other network validation schemas.
🤖 Fix all issues with AI agents
In `@libs/ui-lib/lib/common/utils.ts`:
- Around line 62-65: Two call sites in customManifestsValidationSchema.tsx are
still passing the function reference getMaxFileSizeMessage instead of calling it
with the translation function; update both .test('not-big-file', ...) usages to
call getMaxFileSizeMessage(t) so the translation function is provided (i.e.,
change .test('not-big-file', getMaxFileSizeMessage, validateFileSize) to
.test('not-big-file', getMaxFileSizeMessage(t), validateFileSize)), following
the working example in yamlViewValidationSchema.tsx and keeping validateFileSize
unchanged.
In `@libs/ui-lib/lib/common/validationSchemas/networkingValidation.tsx`:
- Around line 55-62: The validator function that checks primary network CIDR
(the arrow function using openshiftVersion and
isMajorMinorVersionEqualOrGreater) can throw when values is an empty array
because it accesses values?.[0].cidr without guarding the element; fix it by
first reading the primary CIDR with a null-safe access (e.g., const primaryCidr
= values?.[0]?.cidr) and then use primaryCidr in the existing checks (use
!!primaryCidr && isCIDR.v4(...) / isCIDR.v6(...) as appropriate), ensuring you
reference the same openshiftVersion and isMajorMinorVersionEqualOrGreater logic
and isCIDR checks.
In `@libs/ui-lib/lib/common/validationSchemas/ntpValidation.tsx`:
- Around line 11-17: The validator currently treats whitespace-only comma
strings as non-empty and fails because trimCommaSeparatedList(value) can be
empty; update the anonymous validator so after calling
trimCommaSeparatedList(value) you check if the resulting string is empty (or
split and filter out empty/whitespace-only entries) and return true for that
case, otherwise split on ',' and validate each non-empty entry with isIPorDN;
reference trimCommaSeparatedList and isIPorDN when locating the change.
- Around line 23-28: The uniqueness validator currently doesn't handle the case
where trimCommaSeparatedList(value) returns an empty string; update the arrow
function validator to first call trimCommaSeparatedList(value), return true if
that trimmed string is empty, then split that trimmed string by ',' and compare
arr.length to new Set(arr).size to validate uniqueness (reference the existing
trimCommaSeparatedList utility and the inline (value?: string) => { ... }
validator).
In
`@libs/ui-lib/lib/ocm/components/clusterConfiguration/manifestsConfiguration/components/customManifestsValidationSchema.tsx`:
- Around line 69-91: Replace hardcoded validation strings in the Yup schema with
localized calls using t('ai:...'): change 'Required' -> t('ai:required'),
'Number of characters must be 1-255' ->
t('ai:number-of-characters-must-be-1-255') and wrap INCORRECT_FILENAME and
UNIQUE_FOLDER_FILENAME with t(...) (e.g., t(INCORRECT_FILENAME) or if those are
keys replace with t('ai:incorrect-filename') and t('ai:unique-folder-filename')
per codebase convention). Also fix the getMaxFileSizeMessage usage by invoking
it with the i18n function: replace getMaxFileSizeMessage with
getMaxFileSizeMessage(t) in both places (the test call on line with then and the
otherwise branch), keeping existing tests validateFileSize and validateFileType
and preserving uniqueManifestFiles(...) usage.
- Around line 77-88: The conditional in the Yup schema for manifestYaml uses
filename.includes('patch') which misdetects names like "dispatch.yaml"; update
the when predicate on manifestYaml (the function that checks 'filename') to
guard for undefined and use a suffix check such as filename?.endsWith('.patch')
(or a callback form that receives the field value and returns
filename?.endsWith('.patch')) so only files ending with ".patch" skip the
file-content validation in the manifestYaml schema.
In
`@libs/ui-lib/lib/ocm/components/clusterConfiguration/OcmDiscoveryImageConfigForm.tsx`:
- Around line 18-21: The imported type Proxy from
'@openshift-assisted/types/assisted-installer-service' shadows the global Proxy
which Biome flags; change the import to alias it (e.g., import { Proxy as
ServiceProxy }) and update all usages in this file (e.g., types, function
signatures, variables) to the new alias (ServiceProxy) so the linter no longer
conflicts with the global Proxy.
In
`@libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/YamlView/yamlViewValidationSchema.tsx`:
- Around line 23-27: The required message in networkYamlValidationSchema is
hardcoded; change the Yup.string().required('Required field') call to use the
i18n function t instead (e.g., Yup.string().required(t('validation.required'))
or the project's existing required-message key) so the required error message is
translated; update the required invocation in the networkYamlValidationSchema
function accordingly.
🧹 Nitpick comments (4)
libs/ui-lib/lib/common/components/clusterConfiguration/DiscoveryImageConfigForm.tsx (1)
21-26: Consider simplifying the AlertFormikError import path.The import path
../../../common/components/uigoes up three levels tolib/and back down tocommon/components/ui. Since this file is already located inlib/common/components/clusterConfiguration/, a simpler path would be../ui.That said, if this longer path is intentional for consistency with the broader module reorganization in this PR, feel free to keep it as-is.
✨ Optional simplification
-import { AlertFormikError } from '../../../common/components/ui'; +import { AlertFormikError } from '../ui';libs/ui-lib/lib/common/components/clusterWizard/clusterDetailsValidation.ts (1)
100-126: Consider extracting common validation fields.The
nameandbaseDnsDomainvalidation is duplicated in both branches. You could extract these to reduce repetition:♻️ Optional refactor to reduce duplication
export const getClusterDetailsValidationSchema = ({ usedClusterNames, pullSecretSet, validateUniqueName, isOcm, t, }: { usedClusterNames: string[]; pullSecretSet?: boolean; validateUniqueName?: boolean; isOcm?: boolean; t: TFunction; }) => Yup.lazy((values: { baseDnsDomain: string; isSNODevPreview: boolean }) => { + const commonFields = { + name: nameValidationSchema( + t, + usedClusterNames, + values.baseDnsDomain, + validateUniqueName, + isOcm, + ), + baseDnsDomain: isOcm + ? baseDomainValidationSchema(t).required(t('ai:Required field')) + : dnsNameValidationSchema(t).required(t('ai:Required field')), + }; + if (pullSecretSet) { - return Yup.object({ - name: nameValidationSchema( - t, - usedClusterNames, - values.baseDnsDomain, - validateUniqueName, - isOcm, - ), - baseDnsDomain: isOcm - ? baseDomainValidationSchema(t).required(t('ai:Required field')) - : dnsNameValidationSchema(t).required(t('ai:Required field')), - }); + return Yup.object(commonFields); } - return Yup.object({ - name: nameValidationSchema( - t, - usedClusterNames, - values.baseDnsDomain, - validateUniqueName, - isOcm, - ), - baseDnsDomain: isOcm - ? baseDomainValidationSchema(t).required(t('ai:Required field')) - : dnsNameValidationSchema(t).required(t('ai:Required field')), + return Yup.object({ + ...commonFields, pullSecret: pullSecretValidationSchema(t).required(t('ai:Required field')), diskEncryptionTangServers: Yup.array().when('diskEncryptionMode', { // ... rest unchanged }), }); });libs/ui-lib/lib/common/validationSchemas/clusterDetailsValidation.tsx (1)
91-96: Consider using a simpler regex for single-character validation.The code matches individual characters (
trimmed[0],trimmed[trimmed.length - 1]) againstNAME_START_END_REGEX, which is designed for full strings (/^[a-z0-9](.*[a-z0-9])?$/). While this works functionally, it's semantically unclear. A simpler pattern like/^[a-z0-9]$/would be more explicit for single-character checks.libs/ui-lib/lib/cim/components/Agent/BMCForm.tsx (1)
159-166: BiomenoThenPropertylint warning.Lines 161 and 165 use Yup's
.when()with object syntax containingthenproperties, which triggers the Biome lint rule. This is standard Yup API usage and the localization changes are correct. The lint refactoring could be addressed in a follow-up if desired.
...s/clusterConfiguration/manifestsConfiguration/components/customManifestsValidationSchema.tsx
Show resolved
Hide resolved
...s/clusterConfiguration/manifestsConfiguration/components/customManifestsValidationSchema.tsx
Show resolved
Hide resolved
libs/ui-lib/lib/ocm/components/clusterConfiguration/OcmDiscoveryImageConfigForm.tsx
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/YamlView/yamlViewValidationSchema.tsx
Show resolved
Hide resolved
Contributor
|
/retest |
LiorSoffer
reviewed
Feb 4, 2026
...nts/clusterConfiguration/staticIp/components/FormViewHosts/formViewHostsValidationSchema.tsx
Show resolved
Hide resolved
...s/clusterConfiguration/manifestsConfiguration/components/customManifestsValidationSchema.tsx
Outdated
Show resolved
Hide resolved
...s/clusterConfiguration/manifestsConfiguration/components/customManifestsValidationSchema.tsx
Outdated
Show resolved
Hide resolved
...cm/components/clusterConfiguration/staticIp/components/YamlView/yamlViewValidationSchema.tsx
Show resolved
Hide resolved
...s/clusterConfiguration/manifestsConfiguration/components/customManifestsValidationSchema.tsx
Show resolved
Hide resolved
...s/clusterConfiguration/manifestsConfiguration/components/customManifestsValidationSchema.tsx
Show resolved
Hide resolved
LiorSoffer
approved these changes
Feb 5, 2026
jgyselov
force-pushed
the
validation_schema_untangling
branch
from
f51ec5b to
96cd061
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
libs/ui-lib/lib/cim/components/Agent/BMCForm.tsx (1)
154-166:⚠️ Potential issue | 🟠 MajorFix Biome
noThenPropertyby switching Yup.when to callback form.The
thenproperty in the options object conflicts with Biome'snoThenPropertyrule. Yup 1.4.0 supports the callback form as an alternative, which avoids the property name conflict while preserving behavior.♻️ Proposed fix
- macAddress: macAddressValidationSchema(t).when('name', { - is: (name: string) => !!name, - then: (schema) => schema.required(t('ai:MAC has to be specified')), - }), - name: Yup.string().when('macAddress', { - is: (name: string) => !!name, - then: () => Yup.string().required(t('ai:Name has to be specified')), - }), + macAddress: macAddressValidationSchema(t).when('name', (name, schema) => + name ? schema.required(t('ai:MAC has to be specified')) : schema, + ), + name: Yup.string().when('macAddress', (mac, schema) => + mac ? schema.required(t('ai:Name has to be specified')) : schema, + ),
🤖 Fix all issues with AI agents
In `@libs/ui-lib/lib/cim/components/ClusterDeployment/use-networking-formik.ts`:
- Around line 56-77: The Yup .when calls for clusterNetworks and serviceNetworks
use the object form with then/otherwise; change them to the callback form and
fix the parameter signature to accept the first arg as an array destructure: use
when('stackType', ([stackType], schema) => stackType === IPV4_STACK ?
schema.concat(IPv4ValidationSchema) :
schema.concat(dualStackValidationSchema(t('ai:cluster network') or t('ai:service
network'), t, openshiftVersion))) so that clusterNetworksValidationSchema(t) and
serviceNetworkValidationSchema(t) are concatenated correctly with
IPv4ValidationSchema or dualStackValidationSchema based on IPV4_STACK; update
both clusterNetworks and serviceNetworks when usages accordingly.
In `@libs/ui-lib/lib/common/utils.ts`:
- Around line 62-65: The displayed max file size is using MAX_FILE_SIZE_BYTES
while validation allows MAX_FILE_SIZE_BYTES * MAX_FILE_SIZE_OFFSET_FACTOR;
update getMaxFileSizeMessage to compute and display the real enforced limit
(multiply MAX_FILE_SIZE_BYTES by MAX_FILE_SIZE_OFFSET_FACTOR or reuse the same
computed limit used in validateFileSize) so the message matches validation
(refer to getMaxFileSizeMessage, validateFileSize, MAX_FILE_SIZE_BYTES, and
MAX_FILE_SIZE_OFFSET_FACTOR).
In
`@libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/networkConfigurationValidation.ts`:
- Around line 97-107: The when() calls for clusterNetworks and serviceNetworks
must use Yup 1.4.0's callback signature where the first parameter is an array of
values; update clusterNetworksValidationSchema(...).when and
serviceNetworkValidationSchema(...).when to use (values, schema) and access the
stackType via values[0] (e.g., values[0] === IPV4_STACK ?
schema.concat(IPv4ValidationSchema) :
schema.concat(dualStackValidationSchema(..., t, openshiftVersion))). Ensure you
replace the old (stackType, schema) parameters with (values, schema) in both
clusterNetworks and serviceNetworks handlers and keep the same concat logic and
references to IPV4_STACK, IPv4ValidationSchema, dualStackValidationSchema, t,
and openshiftVersion.
🧹 Nitpick comments (3)
libs/ui-lib/lib/cim/components/modals/CimConfiguration/CimConfigurationModal.tsx (1)
103-111: Localization looks good; consider using interpolation for maintainability.The i18n approach for validation messages is correct and aligns with the PR objectives. One optional improvement: the minimum values are hardcoded in translation strings (
"1Gi","10Gi"). If the constantsMIN_DB_VOL_SIZE,MIN_FS_VOL_SIZE, orMIN_IMG_VOL_SIZEchange, the messages would become out of sync.♻️ Optional: Use interpolation with constants
dbVolSize: Yup.number() - .min(MIN_DB_VOL_SIZE, t('ai:Minimal value is 1Gi')) + .min(MIN_DB_VOL_SIZE, t('ai:Minimal value is {{min}}Gi', { min: MIN_DB_VOL_SIZE })) .required(t('ai:Required field')), fsVolSize: Yup.number() - .min(MIN_FS_VOL_SIZE, t('ai:Minimal value is 1Gi')) + .min(MIN_FS_VOL_SIZE, t('ai:Minimal value is {{min}}Gi', { min: MIN_FS_VOL_SIZE })) .required(t('ai:Required field')), imgVolSize: Yup.number() - .min(MIN_IMG_VOL_SIZE, t('ai:Minimal value is 10Gi')) + .min(MIN_IMG_VOL_SIZE, t('ai:Minimal value is {{min}}Gi', { min: MIN_IMG_VOL_SIZE })) .required(t('ai:Required field')),This would require updating the locale file to use:
"ai:Minimal value is {{min}}Gi": "Minimal value is {{min}}Gi"libs/ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/YamlView/YamlView.tsx (1)
10-18: OCM validation schemas should stay non-localized unless requirements changed.This OCM path now threads
tintoyamlViewValidationSchema, which introduces translation keys and the translation workflow. If OCM still doesn’t require localized validation messages, consider keeping this schema non‑i18n or confirm the requirement before proceeding.Based on learnings: Do not localize validation messages in OpenShift Console Management (OCM) components under libs/ui-lib/lib/ocm. Hardcoded strings are acceptable in these files since translations are not required for these validations. When adding/updating validation messages in this path, keep strings stable and avoid triggering translation workflows for these specific components.
libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/networkConfigurationValidation.ts (1)
2-2: OCM validation schemas should stay non-localized unless requirements changed.OCM validations typically remain hardcoded; threading
there introduces translation keys and the translation workflow. Consider keeping these schemas non‑i18n or confirm the requirement before proceeding.Based on learnings: Do not localize validation messages in OpenShift Console Management (OCM) components under libs/ui-lib/lib/ocm. Hardcoded strings are acceptable in these files since translations are not required for these validations. When adding/updating validation messages in this path, keep strings stable and avoid triggering translation workflows for these specific components.
Also applies to: 73-96
libs/ui-lib/lib/cim/components/ClusterDeployment/use-networking-formik.ts
Show resolved
Hide resolved
...b/ocm/components/clusterConfiguration/networkConfiguration/networkConfigurationValidation.ts
Show resolved
Hide resolved
LiorSoffer
approved these changes
Feb 8, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgyselov, LiorSoffer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit cda6370
into
openshift-assisted:master
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libs/ui-lib/lib/common/components/ui/formik/validationSchemas.tsfile into multiple/cimSummary by CodeRabbit
New Features
Bug Fixes
Chores