OCPBUGS-76413: UI freezes when clicking Select button without version

[ElayAharoni]

https://issues.redhat.com/browse/OCPBUGS-76413

Summary by CodeRabbit

Bug Fixes

• Fixed OpenShift version selection modal to prevent invalid form updates when no valid version is selected.

[openshift-ci-robot]

@ElayAharoni: This pull request references Jira Issue OCPBUGS-76413, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-76413

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

A null guard is added to the OpenShiftVersionModal's onClick handler to conditionally update the openshiftVersion form field only when customOpenshiftSelect is not null, preventing updates when the selection is null.

Changes

Cohort / File(s)	Summary
Null Guard in Modal Handler libs/ui-lib/lib/common/components/ui/OpenShiftVersionModal.tsx	Added conditional check to skip setFieldValue call when customOpenshiftSelect is null, preventing unintended form field updates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

size/XS, jira/valid-bug

Suggested reviewers

• rawagner

Poem

🐰 A null guard hops into the modal's gate,
Preventing null updates, oh how great!
No more silent overwrites in the night,
Just conditional logic, shining bright. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly matches the bug being fixed: it references the issue number (OCPBUGS-76413) and describes the specific problem (UI freezes when clicking Select button without version) that the code change addresses.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

libs/ui-lib/lib/common/components/ui/OpenShiftVersionModal.tsx (1)

50-61: The null guard is correct as-is; consider disabling the button for better UX.

The type definition specifies customOpenshiftSelect: string | null (never undefined), so the !== null check properly guards against the only possible falsy value. No change needed there.

The valid improvement is the UX: when a user clicks Select without choosing a version, the modal closes silently. Instead, disable the button until a selection is made—it's clearer and follows standard form patterns for required fields.

Suggested improvement

         <Button
           key="select-custom-ocp"
           variant={ButtonVariant.primary}
+          isDisabled={!values.customOpenshiftSelect}
           onClick={() => {
             if (values.customOpenshiftSelect !== null) {
               setFieldValue('openshiftVersion', values.customOpenshiftSelect);
             }
             onClose();
           }}
         >

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, jgyselov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jgyselov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ElayAharoni]

/jira refresh

[openshift-ci-robot]

@ElayAharoni: This pull request references Jira Issue OCPBUGS-76413, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ElayAharoni]

/jira refresh

[openshift-ci-robot]

@ElayAharoni: This pull request references Jira Issue OCPBUGS-76413, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (mburman@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ElayAharoni: Jira Issue OCPBUGS-76413: All pull requests linked via external trackers have merged:

• openshift-assisted/assisted-installer-ui#3401

Jira Issue OCPBUGS-76413 has been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-76413

Summary by CodeRabbit

Bug Fixes

• Fixed OpenShift version selection modal to prevent invalid form updates when no valid version is selected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.